XCOFF binutils testsuite fix

Message ID 20200707085032.GI28359@bubble.grove.modra.org
State New
Headers show
Series
  • XCOFF binutils testsuite fix
Related show

Commit Message

David Faust via Binutils July 7, 2020, 8:50 a.m.
Avoid an UNRESOLVED test due to "Error: the XCOFF file format does not
support arbitrary sections".

	* testsuite/lib/binutils-common.exp (is_xcoff_format): New.
	* testsuite/binutils-all/objcopy.exp (pr25662): Exclude xcoff.


-- 
Alan Modra
Australia Development Lab, IBM

Patch

diff --git a/binutils/testsuite/binutils-all/objcopy.exp b/binutils/testsuite/binutils-all/objcopy.exp
index dd74860f9e..f857003e33 100644
--- a/binutils/testsuite/binutils-all/objcopy.exp
+++ b/binutils/testsuite/binutils-all/objcopy.exp
@@ -1354,4 +1354,7 @@  if { [istarget pdp11-*-*] } {
     set src "pr25662.s"
 }
 
-objcopy_test "pr25662" $src executable "" "-T$srcdir/$subdir/pr25662.ld"
+#xcoff doesn't support arbitrary sections
+if { ![is_xcoff_format] } {
+    objcopy_test "pr25662" $src executable "" "-T$srcdir/$subdir/pr25662.ld"
+}
diff --git a/binutils/testsuite/lib/binutils-common.exp b/binutils/testsuite/lib/binutils-common.exp
index 491cd8db09..948b910b83 100644
--- a/binutils/testsuite/lib/binutils-common.exp
+++ b/binutils/testsuite/lib/binutils-common.exp
@@ -121,6 +121,16 @@  proc is_som_format {} {
     return 0;
 }
 
+proc is_xcoff_format {} {
+    if { [istarget rs6000-*-*]
+	 || [istarget powerpc*-*-aix*]
+	 || [istarget powerpc*-*-beos*]
+	 || [istarget powerpc*-*-macos*] } {
+	return 1;
+    }
+    return 0;
+}
+
 # True if the object format is known to be 64-bit ELF.
 #
 proc is_elf64 { binary_file } {