[01/30] elf: Include <stdbool.h> in <dl-tunables.h> because bool is used

Message ID 203654d82a17e18f746b6eb1f27af62247f94abd.1592836143.git.fweimer@redhat.com
State New
Headers show
Series
  • RFC: elf: glibc-hwcaps support
Related show

Commit Message

---
 elf/dl-tunables.h | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.25.4

Comments

Tulio Magno Quites Machado Filho June 23, 2020, 9:06 p.m. | #1
Florian Weimer via Libc-alpha <libc-alpha@sourceware.org> writes:

> diff --git a/elf/dl-tunables.h b/elf/dl-tunables.h

> index 969e50327b..f05eb50c2f 100644

> --- a/elf/dl-tunables.h

> +++ b/elf/dl-tunables.h

> @@ -21,6 +21,8 @@

>  #ifndef _TUNABLES_H_

>  #define _TUNABLES_H_

>  

> +#include <stdbool.h>

> +


LGTM.

I think patches #1 and #2 should go in regardless of the other patches.

-- 
Tulio Magno
* Tulio Magno Quites Machado Filho:

> Florian Weimer via Libc-alpha <libc-alpha@sourceware.org> writes:

>

>> diff --git a/elf/dl-tunables.h b/elf/dl-tunables.h

>> index 969e50327b..f05eb50c2f 100644

>> --- a/elf/dl-tunables.h

>> +++ b/elf/dl-tunables.h

>> @@ -21,6 +21,8 @@

>>  #ifndef _TUNABLES_H_

>>  #define _TUNABLES_H_

>>  

>> +#include <stdbool.h>

>> +

>

> LGTM.


Thanks.

> I think patches #1 and #2 should go in regardless of the other patches.


Yes, I think the ld.so --help stuff is independently useful.

Florian

Patch

diff --git a/elf/dl-tunables.h b/elf/dl-tunables.h
index 969e50327b..f05eb50c2f 100644
--- a/elf/dl-tunables.h
+++ b/elf/dl-tunables.h
@@ -21,6 +21,8 @@ 
 #ifndef _TUNABLES_H_
 #define _TUNABLES_H_
 
+#include <stdbool.h>
+
 #if !HAVE_TUNABLES
 static inline void
 __always_inline