[10/19] <libc-symbols.h>: Add libpthread hidden alias support

Message ID 633041a049935f9568fe246d5d4131014fa18dd0.1589884403.git.fweimer@redhat.com
State New
Headers show
Series
  • Signal mask for timer helper thread
Related show

Commit Message

Vitaly Buka via Libc-alpha May 19, 2020, 10:44 a.m.
---
 include/libc-symbols.h | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

-- 
2.25.4

Comments

Vitaly Buka via Libc-alpha May 20, 2020, 2:51 p.m. | #1
On 5/19/20 6:44 AM, Florian Weimer via Libc-alpha wrote:
> ---

>  include/libc-symbols.h | 23 +++++++++++++++++++++++

>  1 file changed, 23 insertions(+)

> 


Defines look good and you'll use them in the next set of patches
to allow libpthread code to call these functions from libc until
the conversion is fully complete (at which point we could clean
it all up).

OK for master.

Tested clean on x86_64 and i686.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

Tested-by: Carlos O'Donell <carlos@redhat.com>


> diff --git a/include/libc-symbols.h b/include/libc-symbols.h

> index 3555cb6f3d..b2f36bc44b 100644

> --- a/include/libc-symbols.h

> +++ b/include/libc-symbols.h

> @@ -737,6 +737,29 @@ for linking")

>  # define libresolv_hidden_data_ver(local, name)

>  #endif

>  

> +#if IS_IN (libpthread)

> +# define libpthread_hidden_proto(name, attrs...) hidden_proto (name, ##attrs)

> +# define libpthread_hidden_tls_proto(name, attrs...) \

> +  hidden_tls_proto (name, ##attrs)

> +# define libpthread_hidden_def(name) hidden_def (name)

> +# define libpthread_hidden_weak(name) hidden_weak (name)

> +# define libpthread_hidden_ver(local, name) hidden_ver (local, name)

> +# define libpthread_hidden_data_def(name) hidden_data_def (name)

> +# define libpthread_hidden_tls_def(name) hidden_tls_def (name)

> +# define libpthread_hidden_data_weak(name) hidden_data_weak (name)

> +# define libpthread_hidden_data_ver(local, name) hidden_data_ver (local, name)

> +#else

> +# define libpthread_hidden_proto(name, attrs...)

> +# define libpthread_hidden_tls_proto(name, attrs...)

> +# define libpthread_hidden_def(name)

> +# define libpthread_hidden_weak(name)

> +# define libpthread_hidden_ver(local, name)

> +# define libpthread_hidden_data_def(name)

> +# define libpthread_hidden_tls_def(name)

> +# define libpthread_hidden_data_weak(name)

> +# define libpthread_hidden_data_ver(local, name)

> +#endif


OK.

> +

>  #if IS_IN (librt)

>  # define librt_hidden_proto(name, attrs...) hidden_proto (name, ##attrs)

>  # define librt_hidden_tls_proto(name, attrs...) \

> 



-- 
Cheers,
Carlos.

Patch

diff --git a/include/libc-symbols.h b/include/libc-symbols.h
index 3555cb6f3d..b2f36bc44b 100644
--- a/include/libc-symbols.h
+++ b/include/libc-symbols.h
@@ -737,6 +737,29 @@  for linking")
 # define libresolv_hidden_data_ver(local, name)
 #endif
 
+#if IS_IN (libpthread)
+# define libpthread_hidden_proto(name, attrs...) hidden_proto (name, ##attrs)
+# define libpthread_hidden_tls_proto(name, attrs...) \
+  hidden_tls_proto (name, ##attrs)
+# define libpthread_hidden_def(name) hidden_def (name)
+# define libpthread_hidden_weak(name) hidden_weak (name)
+# define libpthread_hidden_ver(local, name) hidden_ver (local, name)
+# define libpthread_hidden_data_def(name) hidden_data_def (name)
+# define libpthread_hidden_tls_def(name) hidden_tls_def (name)
+# define libpthread_hidden_data_weak(name) hidden_data_weak (name)
+# define libpthread_hidden_data_ver(local, name) hidden_data_ver (local, name)
+#else
+# define libpthread_hidden_proto(name, attrs...)
+# define libpthread_hidden_tls_proto(name, attrs...)
+# define libpthread_hidden_def(name)
+# define libpthread_hidden_weak(name)
+# define libpthread_hidden_ver(local, name)
+# define libpthread_hidden_data_def(name)
+# define libpthread_hidden_tls_def(name)
+# define libpthread_hidden_data_weak(name)
+# define libpthread_hidden_data_ver(local, name)
+#endif
+
 #if IS_IN (librt)
 # define librt_hidden_proto(name, attrs...) hidden_proto (name, ##attrs)
 # define librt_hidden_tls_proto(name, attrs...) \