Improve svn-rev to search for pattern at line beginning.

Message ID 7d57ec61-8c76-99a9-d94b-52228ce7533f@suse.cz
State New
Headers show
Series
  • Improve svn-rev to search for pattern at line beginning.
Related show

Commit Message

Martin Liška April 3, 2020, 9:13 a.m.
Hi.

It's a small fix that removes the first commit from the following command:

$ git svn-rev 279550
commit bcf3fa7cf5a3d024b507f68ffdfab037f4820781
Author: Andre Vieira <andre.simoesdiasvieira@arm.com>
Date:   Wed Jan 29 14:23:22 2020 +0000

     IRA: Revert 11b8091fb to fix PR 93221
     
     A previous change to simplify LRA introduced in 11b809 (From-SVN: r279550)
     disabled hard register splitting for -O0. This causes a problem on aarch64 in
     cases where parameters are passed in multiple registers (in the bug report an OI
     passed in 2 V4SI registers). This is mandated by the AAPCS.
     
     gcc/ChangeLog:
     2020-01-29  Joel Hutton  <Joel.Hutton@arm.com>
     
             PR target/93221
             * ira.c (ira): Revert use of simplified LRA algorithm.
     
     gcc/testsuite/ChangeLog:
     2020-01-29  Joel Hutton  <Joel.Hutton@arm.com>
     
             PR target/93221
             * gcc.target/aarch64/pr93221.c: New test.

commit 11b8091fb33c894cea20702d3e85389723987910
Author: Eric Botcazou <ebotcazou@adacore.com>
Date:   Wed Dec 18 23:03:23 2019 +0000

     * ira.c (ira): Use simple LRA algorithm when not optimizing.
     
     From-SVN: r279550

Ready for master?
Martin

contrib/ChangeLog:

2020-04-03  Martin Liska  <mliska@suse.cz>

	* gcc-git-customization.sh: Search for the pattern
	at line beginning only.
---
  contrib/gcc-git-customization.sh | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Xionghu Luo via Gcc-patches April 3, 2020, 9:22 a.m. | #1
On Fri, Apr 03, 2020 at 11:13:17AM +0200, Martin Liška wrote:
> 2020-04-03  Martin Liska  <mliska@suse.cz>

> 

> 	* gcc-git-customization.sh: Search for the pattern

> 	at line beginning only.


Ok, thanks.

> diff --git a/contrib/gcc-git-customization.sh b/contrib/gcc-git-customization.sh

> index f3e48316ead..a932bf8c06a 100755

> --- a/contrib/gcc-git-customization.sh

> +++ b/contrib/gcc-git-customization.sh

> @@ -18,7 +18,7 @@ ask () {

>  }

>  

>  # Add a git command to find the git commit equivalent to legacy SVN revision NNN

> -git config alias.svn-rev '!f() { rev=$1; shift; git log --all --grep="From-SVN: r\\?$rev\\b" "${@}"; } ; f'

> +git config alias.svn-rev '!f() { rev=$1; shift; git log --all --grep="^From-SVN: r\\?$rev\\b" "${@}"; } ; f'

>  

>  # Add git commands to convert git commit to monotonically increasing revision number

>  # and vice versa

> 



	Jakub
Joseph Myers April 3, 2020, 6:13 p.m. | #2
Thanks, this matches the commit hook (which only rejects From-SVN: at 
start of line, not elsewhere in a commit message).

-- 
Joseph S. Myers
joseph@codesourcery.com

Patch

diff --git a/contrib/gcc-git-customization.sh b/contrib/gcc-git-customization.sh
index f3e48316ead..a932bf8c06a 100755
--- a/contrib/gcc-git-customization.sh
+++ b/contrib/gcc-git-customization.sh
@@ -18,7 +18,7 @@  ask () {
 }
 
 # Add a git command to find the git commit equivalent to legacy SVN revision NNN
-git config alias.svn-rev '!f() { rev=$1; shift; git log --all --grep="From-SVN: r\\?$rev\\b" "${@}"; } ; f'
+git config alias.svn-rev '!f() { rev=$1; shift; git log --all --grep="^From-SVN: r\\?$rev\\b" "${@}"; } ; f'
 
 # Add git commands to convert git commit to monotonically increasing revision number
 # and vice versa