[pushed,1/3] gdb: remove discard_psymtab function

Message ID 20200329192833.3691258-2-simon.marchi@polymtl.ca
State New
Headers show
Series
  • Small cleanups in the psymtab department
Related show

Commit Message

Pedro Alves via Gdb-patches March 29, 2020, 7:28 p.m.
This function does not add much value, compared to calling the method on
the psymtab_storage object directly.

gdb/ChangeLog:

	* psympriv.h (discard_psymtab): Remove.
	* dbxread.c (dbx_end_psymtab): Update.
	* xcoffread.c (xcoff_end_psymtab): Update.
---
 gdb/ChangeLog   | 6 ++++++
 gdb/dbxread.c   | 2 +-
 gdb/psympriv.h  | 6 ------
 gdb/xcoffread.c | 2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)

-- 
2.25.2

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 82ece136367d..9e5c1cb3ae00 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@ 
+2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
+
+	* psympriv.h (discard_psymtab): Remove.
+	* dbxread.c (dbx_end_psymtab): Update.
+	* xcoffread.c (xcoff_end_psymtab): Update.
+
 2020-03-28  Tom Tromey  <tom@tromey.com>
 
 	* dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
diff --git a/gdb/dbxread.c b/gdb/dbxread.c
index 99f47c0c9177..ecc416e0b5d7 100644
--- a/gdb/dbxread.c
+++ b/gdb/dbxread.c
@@ -2057,7 +2057,7 @@  dbx_end_psymtab (struct objfile *objfile, legacy_psymtab *pst,
          is not empty, but we don't realize that.  Fixing that without slowing
          things down might be tricky.  */
 
-      discard_psymtab (objfile, pst);
+      objfile->partial_symtabs->discard_psymtab (pst);
 
       /* Indicate that psymtab was thrown away.  */
       pst = NULL;
diff --git a/gdb/psympriv.h b/gdb/psympriv.h
index 0effedc4ec2a..79f83a4d6cf9 100644
--- a/gdb/psympriv.h
+++ b/gdb/psympriv.h
@@ -422,12 +422,6 @@  extern void init_psymbol_list (struct objfile *objfile, int total_symbols);
 
 extern void end_psymtab_common (struct objfile *, struct partial_symtab *);
 
-static inline void
-discard_psymtab (struct objfile *objfile, struct partial_symtab *pst)
-{
-  objfile->partial_symtabs->discard_psymtab (pst);
-}
-
 /* Used when recording partial symbol tables.  On destruction,
    discards any partial symbol tables that have been built.  However,
    the tables can be kept by calling the "keep" method.  */
diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c
index 735f8b088258..dca4c46fb119 100644
--- a/gdb/xcoffread.c
+++ b/gdb/xcoffread.c
@@ -2050,7 +2050,7 @@  xcoff_end_psymtab (struct objfile *objfile, legacy_psymtab *pst,
       /* Empty psymtabs happen as a result of header files which don't have
          any symbols in them.  There can be a lot of them.  */
 
-      discard_psymtab (objfile, pst);
+      objfile->partial_symtabs->discard_psymtab (pst);
 
       /* Indicate that psymtab was thrown away.  */
       pst = NULL;