[01/13] nptl: Use .NOTPARALLEL in Makefile only if actually running tests

Message ID 8c70433fadec18875b9114fd97f09bd527a7bd16.1581418947.git.fweimer@redhat.com
State New
Headers show
Series
  • nptl: Move more functions from libpthread to libc
Related show

Commit Message

Florian Weimer Feb. 11, 2020, 11:06 a.m.
It is safe to build the tests in parallel.
---
 nptl/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

-- 
2.24.1

Comments

Adhemerval Zanella Feb. 19, 2020, 5:28 p.m. | #1
On 11/02/2020 08:06, Florian Weimer wrote:
> It is safe to build the tests in parallel.


LGTM, thanks.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>


> ---

>  nptl/Makefile | 4 +++-

>  1 file changed, 3 insertions(+), 1 deletion(-)

> 

> diff --git a/nptl/Makefile b/nptl/Makefile

> index 6f210d60e3..40f27ea7cd 100644

> --- a/nptl/Makefile

> +++ b/nptl/Makefile

> @@ -693,7 +693,9 @@ tst-audit-threads-ENV = LD_AUDIT=$(objpfx)tst-audit-threads-mod1.so

>  

>  CFLAGS-tst-unwind-thread.c += -funwind-tables

>  

> -# The tests here better do not run in parallel

> +# The tests here better do not run in parallel.

> +ifeq ($(run-built-tests),yes)

>  ifneq ($(filter %tests,$(MAKECMDGOALS)),)

>  .NOTPARALLEL:

>  endif

> +endif

>

Patch

diff --git a/nptl/Makefile b/nptl/Makefile
index 6f210d60e3..40f27ea7cd 100644
--- a/nptl/Makefile
+++ b/nptl/Makefile
@@ -693,7 +693,9 @@  tst-audit-threads-ENV = LD_AUDIT=$(objpfx)tst-audit-threads-mod1.so
 
 CFLAGS-tst-unwind-thread.c += -funwind-tables
 
-# The tests here better do not run in parallel
+# The tests here better do not run in parallel.
+ifeq ($(run-built-tests),yes)
 ifneq ($(filter %tests,$(MAKECMDGOALS)),)
 .NOTPARALLEL:
 endif
+endif