[OpenACC] Add acc_device_radeon to name_of_acc_device_t function

Message ID ecd237f2-5cc4-559c-64ab-48d552056a1a@codesourcery.com
State New
Headers show
Series
  • [OpenACC] Add acc_device_radeon to name_of_acc_device_t function
Related show

Commit Message

Frederik Harwath Jan. 29, 2020, 2:28 p.m.
Hi,
we should handle acc_device_radeon in the name_of_acc_device_t function
which is used in libgomp/oacc-init.c to display the name of devices
in several error messages.

Ok to commit this patch to master?

Best regards,
Frederik

Comments

Thomas Schwinge Jan. 29, 2020, 2:45 p.m. | #1
Hi!

On 2020-01-29T15:28:49+0100, "Harwath, Frederik" <frederik@codesourcery.com> wrote:
> we should handle acc_device_radeon in the name_of_acc_device_t function

> which is used in libgomp/oacc-init.c to display the name of devices

> in several error messages.


(Not sure why that was missing in the GCC trunk commit of the AMD GCN
offloading support, given that we did have it on the development branch.)

> Ok to commit this patch to master?


Thanks, OK.  Reviewed-by: Thomas Schwinge <thomas@codesourcery.com>


This also supersedes Tobias' earlier patch,
<http://mid.mail-archive.com/a1ae248c-ce70-f501-d421-e8c9b330802e@codesourcery.com>.
(Sorry, Tobias.)


Grüße
 Thomas


> From 6aacba3e8123ce5e0961857802fd7d8a103aa96b Mon Sep 17 00:00:00 2001

> From: Frederik Harwath <frederik@codesourcery.com>

> Date: Mon, 27 Jan 2020 15:41:26 +0100

> Subject: [PATCH] Add acc_device_radeon to name_of_acc_device_t function

>

> libgomp/

> 	* oacc-init.c (name_of_acc_device_t): Handle acc_device_radeon.

> ---

>  libgomp/oacc-init.c | 1 +

>  1 file changed, 1 insertion(+)

>

> diff --git a/libgomp/oacc-init.c b/libgomp/oacc-init.c

> index 89a30b3e716..ef12b4c16d0 100644

> --- a/libgomp/oacc-init.c

> +++ b/libgomp/oacc-init.c

> @@ -115,6 +115,7 @@ name_of_acc_device_t (enum acc_device_t type)

>      case acc_device_host: return "host";

>      case acc_device_not_host: return "not_host";

>      case acc_device_nvidia: return "nvidia";

> +    case acc_device_radeon: return "radeon";

>      default: unknown_device_type_error (type);

>      }

>    __builtin_unreachable ();

> -- 

> 2.17.1

Patch

From 6aacba3e8123ce5e0961857802fd7d8a103aa96b Mon Sep 17 00:00:00 2001
From: Frederik Harwath <frederik@codesourcery.com>
Date: Mon, 27 Jan 2020 15:41:26 +0100
Subject: [PATCH] Add acc_device_radeon to name_of_acc_device_t function

libgomp/
	* oacc-init.c (name_of_acc_device_t): Handle acc_device_radeon.
---
 libgomp/oacc-init.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libgomp/oacc-init.c b/libgomp/oacc-init.c
index 89a30b3e716..ef12b4c16d0 100644
--- a/libgomp/oacc-init.c
+++ b/libgomp/oacc-init.c
@@ -115,6 +115,7 @@  name_of_acc_device_t (enum acc_device_t type)
     case acc_device_host: return "host";
     case acc_device_not_host: return "not_host";
     case acc_device_nvidia: return "nvidia";
+    case acc_device_radeon: return "radeon";
     default: unknown_device_type_error (type);
     }
   __builtin_unreachable ();
-- 
2.17.1