[3/3] Make the class name in the definition match the declaration

Message ID 20200124141458.171392-4-cbiesinger@chromium.org
State New
Headers show
Series
  • Fix some ARM NetBSD compile errors
Related show

Commit Message

cbiesinger@chromium.org Jan. 24, 2020, 2:14 p.m.
From: Christian Biesinger <cbiesinger@google.com>


Fixes a compile error because the class is actually called
arm_netbsd_nat_target.

gdb/ChangeLog:

2020-01-24  Christian Biesinger  <cbiesinger@google.com>

	* arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
	(arm_netbsd_nat_target::fetch_registers): ...this.
	(arm_nbsd_nat_target::store_registers): Rename to...
	(arm_netbsd_nat_target::store_registers): ...this.

Change-Id: Ibebfab9edeff48f54c32d0745afda1d74d31de92
---
 gdb/arm-nbsd-nat.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.25.0.341.g760bfbb309-goog

Comments

Kamil Rytarowski Jan. 24, 2020, 2:35 p.m. | #1
On 24.01.2020 15:14, cbiesinger@chromium.org wrote:
> From: Christian Biesinger <cbiesinger@google.com>

> 

> Fixes a compile error because the class is actually called

> arm_netbsd_nat_target.

> 

> gdb/ChangeLog:

> 

> 2020-01-24  Christian Biesinger  <cbiesinger@google.com>

> 

> 	* arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...

> 	(arm_netbsd_nat_target::fetch_registers): ...this.

> 	(arm_nbsd_nat_target::store_registers): Rename to...

> 	(arm_netbsd_nat_target::store_registers): ...this.

> 


Looks fine.

Personally I am for unwinding the 'nbsd' term in GDB more widely in more
places.

> Change-Id: Ibebfab9edeff48f54c32d0745afda1d74d31de92

> ---

>  gdb/arm-nbsd-nat.c | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/gdb/arm-nbsd-nat.c b/gdb/arm-nbsd-nat.c

> index 31fe66c724..5072bd09ec 100644

> --- a/gdb/arm-nbsd-nat.c

> +++ b/gdb/arm-nbsd-nat.c

> @@ -191,7 +191,7 @@ fetch_fp_regs (struct regcache *regcache)

>  }

>  

>  void

> -arm_nbsd_nat_target::fetch_registers (struct regcache *regcache, int regno)

> +arm_netbsd_nat_target::fetch_registers (struct regcache *regcache, int regno)

>  {

>    if (regno >= 0)

>      {

> @@ -380,7 +380,7 @@ store_fp_regs (const struct regcache *regcache)

>  }

>  

>  void

> -arm_nbsd_nat_target::store_registers (struct regcache *regcache, int regno)

> +arm_netbsd_nat_target::store_registers (struct regcache *regcache, int regno)

>  {

>    if (regno >= 0)

>      {

>
Tom Tromey Jan. 24, 2020, 3:04 p.m. | #2
>>>>> ">" == cbiesinger  <cbiesinger@chromium.org> writes:


>> 2020-01-24  Christian Biesinger  <cbiesinger@google.com>


>> 	* arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...

>> 	(arm_netbsd_nat_target::fetch_registers): ...this.

>> 	(arm_nbsd_nat_target::store_registers): Rename to...

>> 	(arm_netbsd_nat_target::store_registers): ...this.


This one counts as obvious IMO.
Thank you for doing this.

Tom
H.J. Lu via Gdb-patches Jan. 24, 2020, 3:36 p.m. | #3
On Fri, Jan 24, 2020 at 4:04 PM Tom Tromey <tom@tromey.com> wrote:
>

> >>>>> ">" == cbiesinger  <cbiesinger@chromium.org> writes:

>

> >> 2020-01-24  Christian Biesinger  <cbiesinger@google.com>

>

> >>      * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...

> >>      (arm_netbsd_nat_target::fetch_registers): ...this.

> >>      (arm_nbsd_nat_target::store_registers): Rename to...

> >>      (arm_netbsd_nat_target::store_registers): ...this.

>

> This one counts as obvious IMO.

> Thank you for doing this.


Thanks, will push this patch series. I figured it was easier to group
all the patches together.

Christian

Patch

diff --git a/gdb/arm-nbsd-nat.c b/gdb/arm-nbsd-nat.c
index 31fe66c724..5072bd09ec 100644
--- a/gdb/arm-nbsd-nat.c
+++ b/gdb/arm-nbsd-nat.c
@@ -191,7 +191,7 @@  fetch_fp_regs (struct regcache *regcache)
 }
 
 void
-arm_nbsd_nat_target::fetch_registers (struct regcache *regcache, int regno)
+arm_netbsd_nat_target::fetch_registers (struct regcache *regcache, int regno)
 {
   if (regno >= 0)
     {
@@ -380,7 +380,7 @@  store_fp_regs (const struct regcache *regcache)
 }
 
 void
-arm_nbsd_nat_target::store_registers (struct regcache *regcache, int regno)
+arm_netbsd_nat_target::store_registers (struct regcache *regcache, int regno)
 {
   if (regno >= 0)
     {