gdb/testsuite: Updated includes

Message ID 20200109081731.42472-1-ldurfina@tachyum.com
State New
Headers show
Series
  • gdb/testsuite: Updated includes
Related show

Commit Message

Lukas Durfina Jan. 9, 2020, 8:17 a.m.
Fixed compilation with musl.
---
 gdb/testsuite/ChangeLog         | 5 +++++
 gdb/testsuite/gdb.base/fileio.c | 3 +--
 2 files changed, 6 insertions(+), 2 deletions(-)

-- 
2.17.1

Comments

Joel Brobecker Feb. 1, 2020, 10:15 a.m. | #1
Hello,

I had assumed you pushed the patch, but in double-checking,
it does not seem that way. Apologies for the confusion.

The patch is OK to wait, but can you include the ChangeLog entry
in the revision log? It's been pretty traditional in the GDB
project to have the revision log of the commit be the same as
what's sent by email. I'll take this opportunity to make some
suggestions on how to make the revision log a little more useful
to those who use "git log" (I do it a lot myself).  Typically,
it looks like this:

| Fix compilation error with musl in gdb/testsuite/gdb.base/fileio.c
|
| <in most cases, a short description of the problem to better
| understand the circumstances of the change should be provided here>
|
| gdb/ChangeLog:
|
| 	* gdb.base/fileio.c: Remove #include of <sys/errno.h>.
| 	Replace #include of <sys/fcntl.h> by <fcntl.h>.

Thank you!

On Thu, Jan 09, 2020 at 09:17:31AM +0100, Lukas Durfina wrote:
> Fixed compilation with musl.

> ---

>  gdb/testsuite/ChangeLog         | 5 +++++

>  gdb/testsuite/gdb.base/fileio.c | 3 +--

>  2 files changed, 6 insertions(+), 2 deletions(-)

> 

> diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog

> index 3f243641b8..243721f6cb 100644

> --- a/gdb/testsuite/ChangeLog

> +++ b/gdb/testsuite/ChangeLog

> @@ -1,3 +1,8 @@

> +2020-01-09  Lukas Durfina  <ldurfina@tachyum.com>

> +

> +	* gdb.base/fileio.c: Remove #include of <sys/errno.h>.

> +	Replace #include of <sys/fcntl.h> by <fcntl.h>.

> +

>  2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>

>  

>  	* gdb.base/backtrace.c: New file.

> diff --git a/gdb/testsuite/gdb.base/fileio.c b/gdb/testsuite/gdb.base/fileio.c

> index 7f482a34d3..0f201518b7 100644

> --- a/gdb/testsuite/gdb.base/fileio.c

> +++ b/gdb/testsuite/gdb.base/fileio.c

> @@ -1,13 +1,12 @@

>  #include <stdio.h>

>  #include <stdlib.h>

>  #include <string.h>

> -#include <sys/errno.h>

>  #include <sys/types.h>

> -#include <sys/fcntl.h>

>  #include <sys/stat.h>

>  #include <sys/time.h>

>  #include <errno.h>

>  #include <sys/wait.h>

> +#include <fcntl.h>

>  #include <unistd.h>

>  #include <time.h>

>  /* TESTS :

> -- 

> 2.17.1


-- 
Joel
Lukas Durfina Feb. 3, 2020, 10 a.m. | #2
> 

> Hello,

> 

> I had assumed you pushed the patch, but in double-checking, it does not

> seem that way. Apologies for the confusion.



Hi Joel,

Sorry, I was not sure what you mean by pushing. 
I assume I cannot push directly to repo, so I sent a patch.
Thanks for a hint. I am going to send an updated patch in the following email.

Best regards,
Lukas

> 

> The patch is OK to wait, but can you include the ChangeLog entry in the

> revision log? It's been pretty traditional in the GDB project to have the

> revision log of the commit be the same as what's sent by email. I'll take this

> opportunity to make some suggestions on how to make the revision log a

> little more useful to those who use "git log" (I do it a lot myself).  Typically, it

> looks like this:

> 

> | Fix compilation error with musl in gdb/testsuite/gdb.base/fileio.c

> |

> | <in most cases, a short description of the problem to better

> | understand the circumstances of the change should be provided here>

> |

> | gdb/ChangeLog:

> |

> | 	* gdb.base/fileio.c: Remove #include of <sys/errno.h>.

> | 	Replace #include of <sys/fcntl.h> by <fcntl.h>.

> 

> Thank you!

> 

> On Thu, Jan 09, 2020 at 09:17:31AM +0100, Lukas Durfina wrote:

> > Fixed compilation with musl.

> > ---

> >  gdb/testsuite/ChangeLog         | 5 +++++

> >  gdb/testsuite/gdb.base/fileio.c | 3 +--

> >  2 files changed, 6 insertions(+), 2 deletions(-)

> >

> > diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index

> > 3f243641b8..243721f6cb 100644

> > --- a/gdb/testsuite/ChangeLog

> > +++ b/gdb/testsuite/ChangeLog

> > @@ -1,3 +1,8 @@

> > +2020-01-09  Lukas Durfina  <ldurfina@tachyum.com>

> > +

> > +	* gdb.base/fileio.c: Remove #include of <sys/errno.h>.

> > +	Replace #include of <sys/fcntl.h> by <fcntl.h>.

> > +

> >  2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>

> >

> >  	* gdb.base/backtrace.c: New file.

> > diff --git a/gdb/testsuite/gdb.base/fileio.c

> > b/gdb/testsuite/gdb.base/fileio.c index 7f482a34d3..0f201518b7 100644

> > --- a/gdb/testsuite/gdb.base/fileio.c

> > +++ b/gdb/testsuite/gdb.base/fileio.c

> > @@ -1,13 +1,12 @@

> >  #include <stdio.h>

> >  #include <stdlib.h>

> >  #include <string.h>

> > -#include <sys/errno.h>

> >  #include <sys/types.h>

> > -#include <sys/fcntl.h>

> >  #include <sys/stat.h>

> >  #include <sys/time.h>

> >  #include <errno.h>

> >  #include <sys/wait.h>

> > +#include <fcntl.h>

> >  #include <unistd.h>

> >  #include <time.h>

> >  /* TESTS :

> > --

> > 2.17.1

> 

> --

> Joel
Joel Brobecker Feb. 3, 2020, 10:25 a.m. | #3
> Sorry, I was not sure what you mean by pushing. 

> I assume I cannot push directly to repo, so I sent a patch.

> Thanks for a hint. I am going to send an updated patch in the following email.


I see. I had assumed that you have "Write After Approval" privileges,
which gives you privileges to push after your patch has been reviewed
by a maintainer and approved.

The requirements for you to be given write privileges are that
you have a GDB Copyright Assignment on file with the FSF and
that you submit at least one good patch (this patch qualifies).

For this patch, I will simply push it for you, once you send the updated
version. Normally, we require that all patches are covered by a
copyright assignment (mentioned above), but since your patch is small,
we can include it under the "tiny change" rule.

For the future, if you think you'll be sending further contributions
to GDB, you should start the copyright assignment process. I can send
you the initial paperwork if interested -- just let me know in private.

Thanks
-- 
Joel

> 

> Best regards,

> Lukas

> 

> > 

> > The patch is OK to wait, but can you include the ChangeLog entry in the

> > revision log? It's been pretty traditional in the GDB project to have the

> > revision log of the commit be the same as what's sent by email. I'll take this

> > opportunity to make some suggestions on how to make the revision log a

> > little more useful to those who use "git log" (I do it a lot myself).  Typically, it

> > looks like this:

> > 

> > | Fix compilation error with musl in gdb/testsuite/gdb.base/fileio.c

> > |

> > | <in most cases, a short description of the problem to better

> > | understand the circumstances of the change should be provided here>

> > |

> > | gdb/ChangeLog:

> > |

> > | 	* gdb.base/fileio.c: Remove #include of <sys/errno.h>.

> > | 	Replace #include of <sys/fcntl.h> by <fcntl.h>.

> > 

> > Thank you!

> > 

> > On Thu, Jan 09, 2020 at 09:17:31AM +0100, Lukas Durfina wrote:

> > > Fixed compilation with musl.

> > > ---

> > >  gdb/testsuite/ChangeLog         | 5 +++++

> > >  gdb/testsuite/gdb.base/fileio.c | 3 +--

> > >  2 files changed, 6 insertions(+), 2 deletions(-)

> > >

> > > diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index

> > > 3f243641b8..243721f6cb 100644

> > > --- a/gdb/testsuite/ChangeLog

> > > +++ b/gdb/testsuite/ChangeLog

> > > @@ -1,3 +1,8 @@

> > > +2020-01-09  Lukas Durfina  <ldurfina@tachyum.com>

> > > +

> > > +	* gdb.base/fileio.c: Remove #include of <sys/errno.h>.

> > > +	Replace #include of <sys/fcntl.h> by <fcntl.h>.

> > > +

> > >  2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>

> > >

> > >  	* gdb.base/backtrace.c: New file.

> > > diff --git a/gdb/testsuite/gdb.base/fileio.c

> > > b/gdb/testsuite/gdb.base/fileio.c index 7f482a34d3..0f201518b7 100644

> > > --- a/gdb/testsuite/gdb.base/fileio.c

> > > +++ b/gdb/testsuite/gdb.base/fileio.c

> > > @@ -1,13 +1,12 @@

> > >  #include <stdio.h>

> > >  #include <stdlib.h>

> > >  #include <string.h>

> > > -#include <sys/errno.h>

> > >  #include <sys/types.h>

> > > -#include <sys/fcntl.h>

> > >  #include <sys/stat.h>

> > >  #include <sys/time.h>

> > >  #include <errno.h>

> > >  #include <sys/wait.h>

> > > +#include <fcntl.h>

> > >  #include <unistd.h>

> > >  #include <time.h>

> > >  /* TESTS :

> > > --

> > > 2.17.1

> > 

> > --

> > Joel


-- 
Joel

Patch

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 3f243641b8..243721f6cb 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@ 
+2020-01-09  Lukas Durfina  <ldurfina@tachyum.com>
+
+	* gdb.base/fileio.c: Remove #include of <sys/errno.h>.
+	Replace #include of <sys/fcntl.h> by <fcntl.h>.
+
 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 
 	* gdb.base/backtrace.c: New file.
diff --git a/gdb/testsuite/gdb.base/fileio.c b/gdb/testsuite/gdb.base/fileio.c
index 7f482a34d3..0f201518b7 100644
--- a/gdb/testsuite/gdb.base/fileio.c
+++ b/gdb/testsuite/gdb.base/fileio.c
@@ -1,13 +1,12 @@ 
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
-#include <sys/errno.h>
 #include <sys/types.h>
-#include <sys/fcntl.h>
 #include <sys/stat.h>
 #include <sys/time.h>
 #include <errno.h>
 #include <sys/wait.h>
+#include <fcntl.h>
 #include <unistd.h>
 #include <time.h>
 /* TESTS :