Myanma (mnw_MM, my_MM, shn_MM) locales: Do not use %Op

Message ID 2037647510.516823.1576837147492@poczta.nazwa.pl
State New
Headers show
Series
  • Myanma (mnw_MM, my_MM, shn_MM) locales: Do not use %Op
Related show

Commit Message

Rafal Luzynski Dec. 20, 2019, 10:19 a.m.
I hope the patch is correct but just in case:

-----------------8<--------------------------

From: =?UTF-8?q?Rafa=C5=82=20Lu=C5=BCy=C5=84ski?=

 <digitalfreak@lingonborough.com>
Date: Thu, 19 Dec 2019 21:57:55 +0100
Subject: [PATCH] Myanma (mnw_MM, my_MM, shn_MM) locales: Do not use %Op

The "O" modifier does nothing when used with "%p" so let's better not
use it at all and replace "%Op" with "%p".
---
 localedata/locales/mnw_MM | 2 +-
 localedata/locales/my_MM  | 2 +-
 localedata/locales/shn_MM | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

 d_fmt       "%OC%Oy %b %Od %A"
 t_fmt       "%OH:%OM:%OS %p"
-- 
2.21.0

Comments

Florian Weimer Dec. 20, 2019, 9:01 p.m. | #1
* Rafal Luzynski:

> I hope the patch is correct but just in case:

>

> -----------------8<--------------------------

>

> From: =?UTF-8?q?Rafa=C5=82=20Lu=C5=BCy=C5=84ski?=

>  <digitalfreak@lingonborough.com>

> Date: Thu, 19 Dec 2019 21:57:55 +0100

> Subject: [PATCH] Myanma (mnw_MM, my_MM, shn_MM) locales: Do not use %Op

>

> The "O" modifier does nothing when used with "%p" so let's better not

> use it at all and replace "%Op" with "%p".


The patch looks fine, but I think the subject should say “Myanmar”.
Rafal Luzynski Dec. 20, 2019, 11:53 p.m. | #2
20.12.2019 22:01 Florian Weimer <fw@deneb.enyo.de> wrote:
> [...]

> The patch looks fine, but I think the subject should say “Myanmar”.


Thanks for the feedback.  Wikipedia [1] says the adjective should be
"Myanma" but also mentions other forms commonly used.  I'll wait until
Monday and I will push the patch removing this word (rewording the
subject) unless someone provides the ultimately correct version.

Regards,

Rafal


[1]
https://en.wikipedia.org/wiki/Names_of_Myanmar#Adjectival_forms_and_demonyms
Rafal Luzynski Dec. 23, 2019, 10:55 p.m. | #3
This is the patch that I have just committed.  It also fixes a minor
typo in a comment:

---------------8<----------------------------
From: =?UTF-8?q?Rafa=C5=82=20Lu=C5=BCy=C5=84ski?=

 <digitalfreak@lingonborough.com>
Date: Thu, 19 Dec 2019 21:57:55 +0100
Subject: [PATCH] mnw_MM, my_MM, and shn_MM locales: Do not use %Op

The "O" modifier does nothing when used with "%p" so let's better not
use it at all and replace "%Op" with "%p".
---
 localedata/locales/mnw_MM | 2 +-
 localedata/locales/my_MM  | 2 +-
 localedata/locales/shn_MM | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/localedata/locales/mnw_MM b/localedata/locales/mnw_MM
index 2f089cdbeb..04765ec1d9 100644
--- a/localedata/locales/mnw_MM
+++ b/localedata/locales/mnw_MM
@@ -100,7 +100,7 @@ abday  "<U1012><U102D><U102F><U1010><U103A>";/
        "<U101E><U102D><U102F><U1000><U103A>";/
        "<U101E><U101D><U103A>"
 week          7;19971130;1
-d_t_fmt       "%OC%Oy %b %Od %A %OI:%OM:%OS %Op %Z"
+d_t_fmt       "%OC%Oy %b %Od %A %OI:%OM:%OS %p %Z"
 d_fmt         "%OC%Oy %b %Od %A"
 t_fmt         "%OI:%OM:%OS %p"
 % ဂယး, တ္ၚဲစေၚ်
diff --git a/localedata/locales/my_MM b/localedata/locales/my_MM
index 8463632238..19e39abeea 100644
--- a/localedata/locales/my_MM
+++ b/localedata/locales/my_MM
@@ -155,7 +155,7 @@ mon
        "<U1007><U1014><U103A><U1014><U101D><U102B><U101B><U102E>";/
 	    "<U1012><U102E><U1007><U1004><U103A><U1018><U102C>"
 
 am_pm       "<U1014><U1036><U1014><U1000><U103A>";"<U100A><U1014><U1031>"
-d_t_fmt     "%OC%Oy %b %Od %A %OI:%OM:%OS %Op %Z"
+d_t_fmt     "%OC%Oy %b %Od %A %OI:%OM:%OS %p %Z"
 % Note: the use of %OC requires a patch to strftime_l.h
 d_fmt       "%OC%Oy %b %Od %A"
 t_fmt       "%OI:%OM:%OS %p"
diff --git a/localedata/locales/shn_MM b/localedata/locales/shn_MM
index a837f5fb39..69ac1124e5 100644
--- a/localedata/locales/shn_MM
+++ b/localedata/locales/shn_MM
@@ -140,8 +140,8 @@ mon
        "<U101C><U102D><U1030><U107C><U103A><U1075><U1019><U103A>";/
 	    "<U101C><U102D><U1030><U107C><U103A><U1078><U1035><U1004><U103A>"
 
 am_pm
      "<U1075><U1062><U1004><U103A><U107C><U1082><U103A>";"<U1010><U1062><U1019><U103A><U1038><U1076><U1019><U103A><U1088>"
-d_t_fmt     "%OC%Oy %b %Od %A %OI:%OM:%OS %Op %Z"
-% Note: the Use of %OC reqUires a patch to strftime_l.h
+d_t_fmt     "%OC%Oy %b %Od %A %OI:%OM:%OS %p %Z"
+% Note: the use of %OC requires a patch to strftime_l.h
 d_fmt       "%OC%Oy %b %Od %A"
 t_fmt       "%OH:%OM:%OS %p"
 t_fmt_ampm  "%OI:%OM:%OS %p"
-- 
2.21.0

Patch

diff --git a/localedata/locales/mnw_MM b/localedata/locales/mnw_MM
index 2f089cdbeb..04765ec1d9 100644
--- a/localedata/locales/mnw_MM
+++ b/localedata/locales/mnw_MM
@@ -100,7 +100,7 @@  abday  "<U1012><U102D><U102F><U1010><U103A>";/
        "<U101E><U102D><U102F><U1000><U103A>";/
        "<U101E><U101D><U103A>"
 week          7;19971130;1
-d_t_fmt       "%OC%Oy %b %Od %A %OI:%OM:%OS %Op %Z"
+d_t_fmt       "%OC%Oy %b %Od %A %OI:%OM:%OS %p %Z"
 d_fmt         "%OC%Oy %b %Od %A"
 t_fmt         "%OI:%OM:%OS %p"
 % ဂယး, တ္ၚဲစေၚ်
diff --git a/localedata/locales/my_MM b/localedata/locales/my_MM
index 8463632238..19e39abeea 100644
--- a/localedata/locales/my_MM
+++ b/localedata/locales/my_MM
@@ -155,7 +155,7 @@  mon
        "<U1007><U1014><U103A><U1014><U101D><U102B><U101B><U102E>";/
 	    "<U1012><U102E><U1007><U1004><U103A><U1018><U102C>"
 
 am_pm       "<U1014><U1036><U1014><U1000><U103A>";"<U100A><U1014><U1031>"
-d_t_fmt     "%OC%Oy %b %Od %A %OI:%OM:%OS %Op %Z"
+d_t_fmt     "%OC%Oy %b %Od %A %OI:%OM:%OS %p %Z"
 % Note: the use of %OC requires a patch to strftime_l.h
 d_fmt       "%OC%Oy %b %Od %A"
 t_fmt       "%OI:%OM:%OS %p"
diff --git a/localedata/locales/shn_MM b/localedata/locales/shn_MM
index a837f5fb39..ec37ba6a44 100644
--- a/localedata/locales/shn_MM
+++ b/localedata/locales/shn_MM
@@ -140,7 +140,7 @@  mon
        "<U101C><U102D><U1030><U107C><U103A><U1075><U1019><U103A>";/
 	    "<U101C><U102D><U1030><U107C><U103A><U1078><U1035><U1004><U103A>"
 
 am_pm
      "<U1075><U1062><U1004><U103A><U107C><U1082><U103A>";"<U1010><U1062><U1019><U103A><U1038><U1076><U1019><U103A><U1088>"
-d_t_fmt     "%OC%Oy %b %Od %A %OI:%OM:%OS %Op %Z"
+d_t_fmt     "%OC%Oy %b %Od %A %OI:%OM:%OS %p %Z"
 % Note: the Use of %OC reqUires a patch to strftime_l.h