From patchwork Thu Dec 12 02:35:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [review,v2] Display "main" on initial TUI startup X-Patchwork-Submitter: "Simon Marchi \(Code Review\)" X-Patchwork-Id: 28433 Message-Id: <20191212023505.D143725BB4@gnutoolchain-gerrit.osci.io> To: gdb-patches@sourceware.org Date: Wed, 11 Dec 2019 21:35:02 -0500 From: "Tom Tromey (Code Review)" List-Id: Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/644 ...................................................................... Display "main" on initial TUI startup I noticed that even when there's a symbol file, "tui enable" won't show "main" by default. I think it should, and this patch fixes this. 2019-12-11 Tom Tromey * tui/tui.c (tui_enable): Call tui_display_main. gdb/testsuite/ChangeLog 2019-12-11 Tom Tromey * gdb.tui/list.exp: Check for source on initial listing. Change-Id: Ic7bfc930e1179f5b61111e30a2dae46a98b00064 --- M gdb/ChangeLog M gdb/testsuite/ChangeLog M gdb/testsuite/gdb.tui/list.exp M gdb/tui/tui.c 4 files changed, 11 insertions(+), 1 deletion(-) -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Ic7bfc930e1179f5b61111e30a2dae46a98b00064 Gerrit-Change-Number: 644 Gerrit-PatchSet: 2 Gerrit-Owner: Tom Tromey Gerrit-MessageType: newpatchset diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 58eb3bb..fa571fc 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2019-12-11 Tom Tromey + * tui/tui.c (tui_enable): Call tui_display_main. + +2019-12-11 Tom Tromey + * tui/tui-disasm.c (tui_get_begin_asm_address): Use get_current_source_symtab_and_line, and main_name. diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index b31e8dd..cb575fe 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,9 @@ 2019-12-11 Tom Tromey + * gdb.tui/list.exp: Check for source on initial listing. + +2019-12-11 Tom Tromey + * gdb.tui/resize.exp: Fix regexp. * gdb.tui/regs.exp: Fix regexps. * gdb.tui/main.exp: Fix regexp. diff --git a/gdb/testsuite/gdb.tui/list.exp b/gdb/testsuite/gdb.tui/list.exp index 6efe193..08153c6 100644 --- a/gdb/testsuite/gdb.tui/list.exp +++ b/gdb/testsuite/gdb.tui/list.exp @@ -28,7 +28,7 @@ unsupported "TUI not supported" } -Term::check_contents "initial source listing" "No Source Available" +Term::check_contents "initial source listing" "21 *return 0" Term::command "layout asm" Term::check_contents "asm window shows main" "$hex
" diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c index a0d2e4c..dbc890a 100644 --- a/gdb/tui/tui.c +++ b/gdb/tui/tui.c @@ -513,6 +513,8 @@ if (deprecated_safe_get_selected_frame ()) tui_show_frame_info (deprecated_safe_get_selected_frame ()); + else + tui_display_main (); /* Restore TUI keymap. */ tui_set_key_mode (tui_current_key_mode);