[review,v2] Remove a call to update_exec_info

Message ID 20191212023505.E66E020AF6@gnutoolchain-gerrit.osci.io
State Superseded
Headers show
Series
  • [review,v2] Remove a call to update_exec_info
Related show

Commit Message

Sourceware to Gerrit sync (Code Review) Dec. 12, 2019, 2:35 a.m.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/645
......................................................................

Remove a call to update_exec_info

tui_show_frame_info calls update_exec_info after calling
erase_source_content, but there's no need to do this, as
erase_source_content already clears the exec info.

2019-12-11  Tom Tromey  <tom@tromey.com>

	* tui/tui-stack.c (tui_show_frame_info): Don't call
	update_exec_info.

Change-Id: I63d658561028ac1bc0a0a2b7ac17da1b9c6134fe
---
M gdb/ChangeLog
M gdb/tui/tui-stack.c
2 files changed, 6 insertions(+), 4 deletions(-)




-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I63d658561028ac1bc0a0a2b7ac17da1b9c6134fe
Gerrit-Change-Number: 645
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newpatchset

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index fa571fc..57632dc 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@ 
 2019-12-11  Tom Tromey  <tom@tromey.com>
 
+	* tui/tui-stack.c (tui_show_frame_info): Don't call
+	update_exec_info.
+
+2019-12-11  Tom Tromey  <tom@tromey.com>
+
 	* tui/tui.c (tui_enable): Call tui_display_main.
 
 2019-12-11  Tom Tromey  <tom@tromey.com>
diff --git a/gdb/tui/tui-stack.c b/gdb/tui/tui-stack.c
index 4f6fe8e..f42bd83 100644
--- a/gdb/tui/tui-stack.c
+++ b/gdb/tui/tui-stack.c
@@ -362,10 +362,7 @@ 
 	return 0;
 
       for (struct tui_source_window_base *win_info : tui_source_windows ())
-	{
-	  win_info->erase_source_content ();
-	  win_info->update_exec_info ();
-	}
+	win_info->erase_source_content ();
 
       return 1;
     }