[pushed] Re-highlight windows when needed during TUI startup

Message ID 20191201190409.793592816F@gnutoolchain-gerrit.osci.io
State New
Headers show
Series
  • [pushed] Re-highlight windows when needed during TUI startup
Related show

Commit Message

Tankut Baris Aktemur (Code Review) Dec. 1, 2019, 7:04 p.m.
The original change was created by Tom Tromey.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/607
......................................................................

Re-highlight windows when needed during TUI startup

I noticed that "tui enable" did not correctly show the source window
as having the focus.  Debugging showed that the problem was that
tui_update_variables was called after the windows were drawn, and its
result was being ignored.  This changed the code to re-highlight the
windows if the value changed.

gdb/ChangeLog
2019-12-01  Tom Tromey  <tom@tromey.com>

	* tui/tui.c (tui_enable): Call tui_update_variables earlier.

Change-Id: I1a4563fb431833dd3211a224c9e2df3b936fe9ce
---
M gdb/ChangeLog
M gdb/tui/tui.c
2 files changed, 7 insertions(+), 2 deletions(-)




-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I1a4563fb431833dd3211a224c9e2df3b936fe9ce
Gerrit-Change-Number: 607
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newpatchset

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 86fa840..67b76dc 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@ 
 2019-12-01  Tom Tromey  <tom@tromey.com>
 
+	* tui/tui.c (tui_enable): Call tui_update_variables earlier.
+
+2019-12-01  Tom Tromey  <tom@tromey.com>
+
 	* NEWS: Document new settings.
 	* tui/tui-wingeneral.c (box_win): Apply appropriate border style.
 	* tui/tui-win.c (_initialize_tui_win): Add border style
diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c
index 3f5ab41..dc0d22f 100644
--- a/gdb/tui/tui.c
+++ b/gdb/tui/tui.c
@@ -496,8 +496,9 @@ 
   tui_install_hooks ();
   rl_startup_hook = tui_rl_startup_hook;
 
-  tui_update_variables ();
-  
+  if (tui_update_variables ())
+    tui_rehighlight_all ();
+
   tui_setup_io (1);
 
   tui_active = 1;