gdb/testsuite: test runs only on x86_64

Message ID 20191121073728.41426-1-ldurfina@tachyum.com
State New
Headers show
Series
  • gdb/testsuite: test runs only on x86_64
Related show

Commit Message

Lukas Durfina Nov. 21, 2019, 7:37 a.m.
From: Lukas Durfina <ldurfina@tachyum.com>


---
 gdb/testsuite/gdb.arch/amd64-eval.exp | 5 +++++
 1 file changed, 5 insertions(+)

-- 
2.17.1

Comments

Simon Marchi Nov. 21, 2019, 3:37 p.m. | #1
On 2019-11-21 2:37 a.m., ldurfina@tachyum.com wrote:
> From: Lukas Durfina <ldurfina@tachyum.com>

> 

> ---

>  gdb/testsuite/gdb.arch/amd64-eval.exp | 5 +++++

>  1 file changed, 5 insertions(+)

> 

> diff --git a/gdb/testsuite/gdb.arch/amd64-eval.exp b/gdb/testsuite/gdb.arch/amd64-eval.exp

> index 4b5c28e7ce..dd2482435a 100644

> --- a/gdb/testsuite/gdb.arch/amd64-eval.exp

> +++ b/gdb/testsuite/gdb.arch/amd64-eval.exp

> @@ -17,6 +17,11 @@

>  

>  # This testcase exercises evaluation with amd64 calling conventions.

>  

> +if { ![istarget x86_64-*-* ] || ![is_lp64_target] } {

> +    verbose "Skipping x86_64 eval test."

> +    return

> +}

> +

>  standard_testfile .cc

>  

>  if { [prepare_for_testing "failed to prepare" $testfile $srcfile \

> -- 

> 2.17.1

> 


Thanks, nice catch.  I have pushed the patch with the following ChangeLog entry:

2019-11-21  Lukas Durfina  <ldurfina@tachyum.com>

	* gdb.arch/amd64-eval.exp: Skip test if target is not x86-64.

Simon

Patch

diff --git a/gdb/testsuite/gdb.arch/amd64-eval.exp b/gdb/testsuite/gdb.arch/amd64-eval.exp
index 4b5c28e7ce..dd2482435a 100644
--- a/gdb/testsuite/gdb.arch/amd64-eval.exp
+++ b/gdb/testsuite/gdb.arch/amd64-eval.exp
@@ -17,6 +17,11 @@ 
 
 # This testcase exercises evaluation with amd64 calling conventions.
 
+if { ![istarget x86_64-*-* ] || ![is_lp64_target] } {
+    verbose "Skipping x86_64 eval test."
+    return
+}
+
 standard_testfile .cc
 
 if { [prepare_for_testing "failed to prepare" $testfile $srcfile \