[i386] : --enable-frame-pointer for cygwin and mingw

Message ID CAFULd4YmrSczmXrXkS8TuWDmeVtKAEA0YSDgkxo1EZMh0NA8ug@mail.gmail.com
State New
Headers show
Series
  • [i386] : --enable-frame-pointer for cygwin and mingw
Related show

Commit Message

Uros Bizjak May 13, 2019, 10:15 a.m.
On Thu, May 9, 2019 at 11:55 AM Thomas Schwinge <thomas@codesourcery.com> wrote:

> On Sun, 10 Feb 2019 20:51:39 +0100, Uros Bizjak <ubizjak@gmail.com> wrote:

> > On Fri, Feb 8, 2019 at 1:24 PM Uros Bizjak <ubizjak@gmail.com> wrote:

> > > Attached patch fixes --enable-frame-pointer handling [...]

>

> ACK.

>

> > Please note that this fix will re-enable frame pointer for all targets

> > but linux* or darwin[[8912]]. However, since builds for e.g. cygwin

> > and mingw survived just well without frame pointers in the mean time,

> > we should probably list these targets as targets without frame

> > pointers by default.

>

> I agree, this would cause the least surprise, to simply keep the previous

> default of '--disable-frame-pointer'.  Until such a global change is

> agreed on, and made...


I plan to commit the attached patch later today.

2019-05-13  UroŇ° Bizjak  <ubizjak@gmail.com>

    PR target/89221
    * configure.ac (--enable-frame-pointer):
    Disable by default for cygwin and mingw.
    * configure: Regenerate.

Uros.

Patch

diff --git a/gcc/configure b/gcc/configure
index 947d263a6174..3cab176e5018 100755
--- a/gcc/configure
+++ b/gcc/configure
@@ -12197,7 +12197,7 @@  if test "${enable_frame_pointer+set}" = set; then :
 else
 
 case $target_os in
-linux* | gnu* | darwin[8912]*)
+linux* | gnu* | darwin[8912]* | cygwin* | mingw*)
   # Enable -fomit-frame-pointer by default for these systems with DWARF2.
   enable_frame_pointer=no
   ;;
diff --git a/gcc/configure.ac b/gcc/configure.ac
index bfcdf526e446..264f36fb78a8 100644
--- a/gcc/configure.ac
+++ b/gcc/configure.ac
@@ -1884,7 +1884,7 @@  AC_ARG_ENABLE(frame-pointer,
 		[enable -fno-omit-frame-pointer by default for x86])], [],
 [
 case $target_os in
-linux* | gnu* | darwin[[8912]]*)
+linux* | gnu* | darwin[[8912]]* | cygwin* | mingw*)
   # Enable -fomit-frame-pointer by default for these systems with DWARF2.
   enable_frame_pointer=no
   ;;