[objdump/ARM] Fix bxns mask

Message ID e47909b1-a982-2d36-e445-4f747c1cdbde@foss.arm.com
State New
Headers show
Series
  • [objdump/ARM] Fix bxns mask
Related show

Commit Message

Thomas Preudhomme Feb. 16, 2018, 3:54 p.m.
Bit 7 of BXNS is a fixed bit which distinguish it from BLXNS. Yet it is
not set in the disassembler entry mask. This patch fixes that.

ChangeLog entry is as follows:

*** opcodes/ChangeLog ***

2018-02-14  Thomas Preud'homme  <thomas.preudhomme@arm.com>

	* arm-dis.c (thumb_opcodes): Fix BXNS mask.

Testing: Ran testsuite for arm-none-eabi targets which does not show any
regression. In particular the following tests are still fine:
- ARMv8-M Baseline Security Extensions instructions
- ARMv8-M Mainline Security Extensions instructions (1)
- ARMv8-M Mainline with DSP instructions (Security Extensions 1)

Is this ok for master branch?

Best regards,

Thomas

Comments

Nick Clifton Feb. 19, 2018, 11:54 a.m. | #1
Hi Thomas,

> 2018-02-14  Thomas Preud'homme  <thomas.preudhomme@arm.com>

> 

>     * arm-dis.c (thumb_opcodes): Fix BXNS mask.


Approved - please apply.

Cheers
  Nick
Thomas Preudhomme March 15, 2018, 5:56 p.m. | #2
Hi Nick,

Is this ok to backport to binutils 2.30? It applies cleanly and does not show 
any regression when running the testsuite for arm-none-eabi targets.

Best regards,

Thomas

On 19/02/18 11:54, Nick Clifton wrote:
> Hi Thomas,

> 

>> 2018-02-14  Thomas Preud'homme  <thomas.preudhomme@arm.com>

>>

>>      * arm-dis.c (thumb_opcodes): Fix BXNS mask.

> 

> Approved - please apply.

> 

> Cheers

>    Nick

> 

>
Nick Clifton March 16, 2018, 10:58 a.m. | #3
Hi Thomas,

> Is this ok to backport to binutils 2.30? It applies cleanly and does not show any regression when running the testsuite for arm-none-eabi targets.


Sure - please do.

Cheers
  Nick
Thomas Preudhomme March 16, 2018, 2:25 p.m. | #4
Done, thanks! Below the ChangeLog entry:

2018-03-16  Thomas Preud'homme  <thomas.preudhomme@arm.com>

         Backport from mainline
         2018-02-19  Thomas Preud'homme  <thomas.preudhomme@arm.com>

         * arm-dis.c (thumb_opcodes): Fix BXNS mask.

Best regards,

Thomas

On 16/03/18 10:58, Nick Clifton wrote:
> Hi Thomas,

> 

>> Is this ok to backport to binutils 2.30? It applies cleanly and does not show any regression when running the testsuite for arm-none-eabi targets.

> 

> Sure - please do.

> 

> Cheers

>    Nick

>

Patch

diff --git a/opcodes/arm-dis.c b/opcodes/arm-dis.c
index 5efe0316222d077a61831c743593e96e2ff6d77e..afa9410b4f4b4bbcaba5d4a61bdf72c75487b969 100644
--- a/opcodes/arm-dis.c
+++ b/opcodes/arm-dis.c
@@ -2530,7 +2530,7 @@  static const struct opcode16 thumb_opcodes[] =
 
   /* ARMv8-M Security Extensions instructions.  */
   {ARM_FEATURE_CORE_HIGH (ARM_EXT2_V8M), 0x4784, 0xff87, "blxns\t%3-6r"},
-  {ARM_FEATURE_CORE_HIGH (ARM_EXT2_V8M), 0x4704, 0xff07, "bxns\t%3-6r"},
+  {ARM_FEATURE_CORE_HIGH (ARM_EXT2_V8M), 0x4704, 0xff87, "bxns\t%3-6r"},
 
   /* ARM V8 instructions.  */
   {ARM_FEATURE_CORE_LOW (ARM_EXT_V8),  0xbf50, 0xffff, "sevl%c"},