[19/25] gdb/tic6x: Use default gdbarch methods where possible

Message ID bffaf1ab841419758bccd556d7da966d66f9d916.1553721878.git.andrew.burgess@embecosm.com
State New
Headers show
Series
  • Make use of default gdbarch methods for some more targets
Related show

Commit Message

Andrew Burgess March 27, 2019, 9:34 p.m.
Make use of the default gdbarch methods for gdbarch_dummy_id, and
gdbarch_unwind_sp where possible.

I have not tested this change but, by inspecting the code, I believe
the default methods are equivalent to the code being deleted.

gdb/ChangeLog:

	* tic6x-tdep.c (tic6x_unwind_sp): Delete.
	(tic6x_dummy_id): Delete.
	(tic6x_gdbarch_init): Don't register deleted functions with
	gdbarch.
---
 gdb/ChangeLog    |  7 +++++++
 gdb/tic6x-tdep.c | 24 +-----------------------
 2 files changed, 8 insertions(+), 23 deletions(-)

-- 
2.14.5

Comments

Kevin Buettner March 27, 2019, 10:21 p.m. | #1
On Wed, 27 Mar 2019 21:34:15 +0000
Andrew Burgess <andrew.burgess@embecosm.com> wrote:

> gdb/ChangeLog:

> 

> 	* tic6x-tdep.c (tic6x_unwind_sp): Delete.

> 	(tic6x_dummy_id): Delete.

> 	(tic6x_gdbarch_init): Don't register deleted functions with

> 	gdbarch.


Okay.

Kevin

Patch

diff --git a/gdb/tic6x-tdep.c b/gdb/tic6x-tdep.c
index 61dc676de3b..ffc1b989d55 100644
--- a/gdb/tic6x-tdep.c
+++ b/gdb/tic6x-tdep.c
@@ -376,15 +376,6 @@  tic6x_unwind_pc (struct gdbarch *gdbarch, struct frame_info *next_frame)
   return extract_typed_address (buf, builtin_type (gdbarch)->builtin_func_ptr);
 }
 
-/* This is the implementation of gdbarch method unwind_sp.  */
-
-static CORE_ADDR
-tic6x_unwind_sp (struct gdbarch *gdbarch, struct frame_info *this_frame)
-{
-  return frame_unwind_register_unsigned (this_frame, TIC6X_SP_REGNUM);
-}
-
-
 /* Frame base handling.  */
 
 static struct tic6x_unwind_cache*
@@ -811,16 +802,6 @@  tic6x_return_value (struct gdbarch *gdbarch, struct value *function,
   return RETURN_VALUE_REGISTER_CONVENTION;
 }
 
-/* This is the implementation of gdbarch method dummy_id.  */
-
-static struct frame_id
-tic6x_dummy_id (struct gdbarch *gdbarch, struct frame_info *this_frame)
-{
-  return frame_id_build
-    (get_frame_register_unsigned (this_frame, TIC6X_SP_REGNUM),
-     get_frame_pc (this_frame));
-}
-
 /* Get the alignment requirement of TYPE.  */
 
 static int
@@ -1283,7 +1264,6 @@  tic6x_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
 				       tic6x_sw_breakpoint_from_kind);
 
   set_gdbarch_unwind_pc (gdbarch, tic6x_unwind_pc);
-  set_gdbarch_unwind_sp (gdbarch, tic6x_unwind_sp);
 
   /* Unwinding.  */
   dwarf2_append_unwinders (gdbarch);
@@ -1302,9 +1282,7 @@  tic6x_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
 
   set_gdbarch_return_value (gdbarch, tic6x_return_value);
 
-  set_gdbarch_dummy_id (gdbarch, tic6x_dummy_id);
-
-  /* Enable inferior call support.  */
+    /* Enable inferior call support.  */
   set_gdbarch_push_dummy_call (gdbarch, tic6x_push_dummy_call);
 
   set_gdbarch_get_longjmp_target (gdbarch, tic6x_get_longjmp_target);