[OBV] Fix powerpc build

Message ID 20190326171745.96435-1-alan.hayward@arm.com
State New
Headers show
Series
  • [OBV] Fix powerpc build
Related show

Commit Message

Alan Hayward March 26, 2019, 5:17 p.m.
gdb/ChangeLog:

2019-03-26  Alan Hayward  <alan.hayward@arm.com>

        * ppc-linux-nat.c: Add include
---
 gdb/ppc-linux-nat.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.20.1 (Apple Git-117)

Comments

Kevin Buettner March 26, 2019, 10:56 p.m. | #1
On Tue, 26 Mar 2019 17:17:55 +0000
Alan Hayward <Alan.Hayward@arm.com> wrote:

> gdb/ChangeLog:

> 

> 2019-03-26  Alan Hayward  <alan.hayward@arm.com>

> 

>         * ppc-linux-nat.c: Add include


The ChangeLog entry needs a period.  It'd also be nice to mention
what you're including.  I.e.

	* ppc-linux-nat.c (linux-tdep.h): Add include.

Kevin
Alan Hayward March 27, 2019, 8:42 a.m. | #2
> On 26 Mar 2019, at 22:56, Kevin Buettner <kevinb@redhat.com> wrote:

> 

> On Tue, 26 Mar 2019 17:17:55 +0000

> Alan Hayward <Alan.Hayward@arm.com> wrote:

> 

>> gdb/ChangeLog:

>> 

>> 2019-03-26  Alan Hayward  <alan.hayward@arm.com>

>> 

>>        * ppc-linux-nat.c: Add include

> 

> The ChangeLog entry needs a period.


Thankfully I spotted that after I sent the email, but before I pushed.
It’s fixed in the actual commit.


>  It'd also be nice to mention

> what you're including.  I.e.

> 

> 	* ppc-linux-nat.c (linux-tdep.h): Add include.


Will do in future.


Alan.


> 

> Kevin
Andreas Schwab March 27, 2019, 9:07 a.m. | #3
On Mär 27 2019, Alan Hayward <Alan.Hayward@arm.com> wrote:

>> On 26 Mar 2019, at 22:56, Kevin Buettner <kevinb@redhat.com> wrote:

>> 

>>  It'd also be nice to mention

>> what you're including.  I.e.

>> 

>> 	* ppc-linux-nat.c (linux-tdep.h): Add include.

>

> Will do in future.


I think the convention is to write it like this:

	* ppc-linux-nat.c: Include "linux-tdep.h".

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Patch

diff --git a/gdb/ppc-linux-nat.c b/gdb/ppc-linux-nat.c
index 3a6bbf4163..628e3d5e8f 100644
--- a/gdb/ppc-linux-nat.c
+++ b/gdb/ppc-linux-nat.c
@@ -51,6 +51,7 @@ 
 #include "arch/ppc-linux-common.h"
 #include "arch/ppc-linux-tdesc.h"
 #include "nat/ppc-linux.h"
+#include "linux-tdep.h"
 
 /* Similarly for the hardware watchpoint support.  These requests are used
    when the PowerPC HWDEBUG ptrace interface is not available.  */