[OBV] Fix Arm build

Message ID 20190326114239.34311-1-alan.hayward@arm.com
State New
Headers show
Series
  • [OBV] Fix Arm build
Related show

Commit Message

Alan Hayward March 26, 2019, 11:43 a.m.
[Should have checked this when I fixed s390 build.
 Going to see about getting an Arm box into buildbot - booting Linux
 in Qemu-AArch64 in AArch32 mode on a AArch64 box might be fast enough to
 use as an Arm machine]


Add missing include.

2019-03-26  Alan Hayward  <alan.hayward@arm.com>

        * arm-linux-nat.c: Add include.
---
 gdb/arm-linux-nat.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.20.1 (Apple Git-117)

Comments

Simon Marchi March 26, 2019, 5:03 p.m. | #1
On 2019-03-26 7:43 a.m., Alan Hayward wrote:
> [Should have checked this when I fixed s390 build.

>  Going to see about getting an Arm box into buildbot - booting Linux

>  in Qemu-AArch64 in AArch32 mode on a AArch64 box might be fast enough to

>  use as an Arm machine]

> 

> 

> Add missing include.

> 

> 2019-03-26  Alan Hayward  <alan.hayward@arm.com>

> 

>         * arm-linux-nat.c: Add include.

> ---

>  gdb/arm-linux-nat.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/gdb/arm-linux-nat.c b/gdb/arm-linux-nat.c

> index b54bd5afe9..52668da9fc 100644

> --- a/gdb/arm-linux-nat.c

> +++ b/gdb/arm-linux-nat.c

> @@ -38,6 +38,7 @@

>  #include <sys/procfs.h>

>  

>  #include "nat/linux-ptrace.h"

> +#include "linux-tdep.h"

>  

>  /* Prototypes for supply_gregset etc.  */

>  #include "gregset.h"

> 



powerpc seems to have this problem as well :)

/home/smarchi/src/binutils-gdb/gdb/ppc-linux-nat.c:2616:22: error: ‘linux_get_hwcap2’ was not declared in this scope

Simon
Alan Hayward March 26, 2019, 5:14 p.m. | #2
> On 26 Mar 2019, at 17:03, Simon Marchi <simark@simark.ca> wrote:

> 

> On 2019-03-26 7:43 a.m., Alan Hayward wrote:

>> [Should have checked this when I fixed s390 build.

>> Going to see about getting an Arm box into buildbot - booting Linux

>> in Qemu-AArch64 in AArch32 mode on a AArch64 box might be fast enough to

>> use as an Arm machine]

>> 

>> 

>> Add missing include.

>> 

>> 2019-03-26  Alan Hayward  <alan.hayward@arm.com>

>> 

>>        * arm-linux-nat.c: Add include.

>> ---

>> gdb/arm-linux-nat.c | 1 +

>> 1 file changed, 1 insertion(+)

>> 

>> diff --git a/gdb/arm-linux-nat.c b/gdb/arm-linux-nat.c

>> index b54bd5afe9..52668da9fc 100644

>> --- a/gdb/arm-linux-nat.c

>> +++ b/gdb/arm-linux-nat.c

>> @@ -38,6 +38,7 @@

>> #include <sys/procfs.h>

>> 

>> #include "nat/linux-ptrace.h"

>> +#include "linux-tdep.h"

>> 

>> /* Prototypes for supply_gregset etc.  */

>> #include "gregset.h"

>> 

> 

> 

> powerpc seems to have this problem as well :)

> 

> /home/smarchi/src/binutils-gdb/gdb/ppc-linux-nat.c:2616:22: error: ‘linux_get_hwcap2’ was not declared in this scope

> 

> Simon


Will fix this too....  :(


Alan.

Patch

diff --git a/gdb/arm-linux-nat.c b/gdb/arm-linux-nat.c
index b54bd5afe9..52668da9fc 100644
--- a/gdb/arm-linux-nat.c
+++ b/gdb/arm-linux-nat.c
@@ -38,6 +38,7 @@ 
 #include <sys/procfs.h>
 
 #include "nat/linux-ptrace.h"
+#include "linux-tdep.h"
 
 /* Prototypes for supply_gregset etc.  */
 #include "gregset.h"