[1/5] Add define _COMPILING_NEWLIB for arm to configure.host, as it is obviously needed

Message ID 20180212112345.17392-1-info@jasoon.nl
State New
Headers show
Series
  • [1/5] Add define _COMPILING_NEWLIB for arm to configure.host, as it is obviously needed
Related show

Commit Message

Jaap de Wolff Feb. 12, 2018, 11:23 a.m.
Signed-off-by: Jaap de Wolff <jaap@stretch.de-wolff.org>

---
 newlib/configure.host | 1 +
 1 file changed, 1 insertion(+)

-- 
2.11.0

Comments

Corinna Vinschen Feb. 13, 2018, 9:41 a.m. | #1
This patchset looks good to me, but I'd like to have some input from the
ARM guys.


Thanks,
Corinna


On Feb 12 12:23, Jaap de Wolff wrote:
> Signed-off-by: Jaap de Wolff <jaap@stretch.de-wolff.org>

> ---

>  newlib/configure.host | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/newlib/configure.host b/newlib/configure.host

> index eb645868b..5985f1376 100644

> --- a/newlib/configure.host

> +++ b/newlib/configure.host

> @@ -410,6 +410,7 @@ case "${host}" in

>  	signal_dir=

>  	;;

>    arm*-*-*)

> +	newlib_cflags="${newlib_cflags} -D_COMPILING_NEWLIB"

>  	sys_dir=arm

>  	if [ "x${newlib_may_supply_syscalls}" = "xno" ] ; then

>  	  have_crt0="no"

> -- 

> 2.11.0


-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat
Nick Clifton Feb. 16, 2018, 10:49 a.m. | #2
Hi Corinna,

> This patchset looks good to me, but I'd like to have some input from the

> ARM guys.


Looks good to me.  Please can it be applied.

Cheers
  Nick
Corinna Vinschen Feb. 16, 2018, 12:46 p.m. | #3
On Feb 16 10:49, Nick Clifton wrote:
> Hi Corinna,

> 

> > This patchset looks good to me, but I'd like to have some input from the

> > ARM guys.

> 

> Looks good to me.  Please can it be applied.

> 

> Cheers

>   Nick


Pushed.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Patch

diff --git a/newlib/configure.host b/newlib/configure.host
index eb645868b..5985f1376 100644
--- a/newlib/configure.host
+++ b/newlib/configure.host
@@ -410,6 +410,7 @@  case "${host}" in
 	signal_dir=
 	;;
   arm*-*-*)
+	newlib_cflags="${newlib_cflags} -D_COMPILING_NEWLIB"
 	sys_dir=arm
 	if [ "x${newlib_may_supply_syscalls}" = "xno" ] ; then
 	  have_crt0="no"