Again: [PATCH]Warning while compiling newlib-nano for eabi

Message ID 008f01d3a108$b5166370$1f432a50$@jasoon.nl
State Superseded
Headers show
Series
  • Again: [PATCH]Warning while compiling newlib-nano for eabi
Related show

Commit Message

Jaap de Wolff Feb. 8, 2018, 6:14 p.m.
> -----Oorspronkelijk bericht-----

> Van: newlib-owner@sourceware.org [mailto:newlib-owner@sourceware.org]

> Namens Corinna Vinschen

> Verzonden: Thursday, February 8, 2018 4:34 PM

> Aan: newlib@sourceware.org

> Onderwerp: Re: [PATCH]Warning while compiling newlib-nano for eabi

> 

...
> 

> /* */  rather than //, please, just as in the other patches.

> 

> > +extern int __cxa_atexit (void (*) (void *), void *, void *);

> > +

> >  /* Register a function to be called by exit or when a shared library

> >     is unloaded.  This routine is like __cxa_atexit, but uses the

> >     calling sequence required by the ARM EABI.  */

> 

> Thanks,

> Corinna

> 

> --

> Corinna Vinschen

> Cygwin Maintainer

> Red Hat

Corinna, you are totally right. 
I am used to write C++ and C# code.

Jaap de Wolff
New patch:

Comments

Corinna Vinschen Feb. 8, 2018, 7:56 p.m. | #1
On Feb  8 19:14, Jaap de Wolff wrote:
> 

> 

> > -----Oorspronkelijk bericht-----

> > Van: newlib-owner@sourceware.org [mailto:newlib-owner@sourceware.org]

> > Namens Corinna Vinschen

> > Verzonden: Thursday, February 8, 2018 4:34 PM

> > Aan: newlib@sourceware.org

> > Onderwerp: Re: [PATCH]Warning while compiling newlib-nano for eabi

> > 

> ...

> > 

> > /* */  rather than //, please, just as in the other patches.

> > 

> > > +extern int __cxa_atexit (void (*) (void *), void *, void *);

> > > +

> > >  /* Register a function to be called by exit or when a shared library

> > >     is unloaded.  This routine is like __cxa_atexit, but uses the

> > >     calling sequence required by the ARM EABI.  */

> > 

> > Thanks,

> > Corinna

> > 

> > --

> > Corinna Vinschen

> > Cygwin Maintainer

> > Red Hat

> Corinna, you are totally right. 

> I am used to write C++ and C# code.

> 

> Jaap de Wolff

> New patch:

> ==================PATCH======================

> diff --git a/newlib/libc/sys/arm/aeabi_atexit.c b/newlib/libc/sys/arm/aeabi_atexit.c

> index 4b600e250..9ecd19d05 100644

> --- a/newlib/libc/sys/arm/aeabi_atexit.c

> +++ b/newlib/libc/sys/arm/aeabi_atexit.c

> @@ -1,5 +1,8 @@

>  #include <stdlib.h>

>  

> +//forward declaration


If that's a v2 patch, there's something gone wrong here....

> +extern int __cxa_atexit (void (*) (void *), void *, void *);

> +

>  /* Register a function to be called by exit or when a shared library

>     is unloaded.  This routine is like __cxa_atexit, but uses the

>     calling sequence required by the ARM EABI.  */



Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Patch

==================PATCH======================
diff --git a/newlib/libc/sys/arm/aeabi_atexit.c b/newlib/libc/sys/arm/aeabi_atexit.c
index 4b600e250..9ecd19d05 100644
--- a/newlib/libc/sys/arm/aeabi_atexit.c
+++ b/newlib/libc/sys/arm/aeabi_atexit.c
@@ -1,5 +1,8 @@ 
 #include <stdlib.h>
 
+//forward declaration
+extern int __cxa_atexit (void (*) (void *), void *, void *);
+
 /* Register a function to be called by exit or when a shared library
    is unloaded.  This routine is like __cxa_atexit, but uses the
    calling sequence required by the ARM EABI.  */