Use upper case for metasyntactic variables in "help find"

Message ID 20190214150108.25937-1-tromey@adacore.com
State New
Headers show
Series
  • Use upper case for metasyntactic variables in "help find"
Related show

Commit Message

Tom Tromey Feb. 14, 2019, 3:01 p.m.
While answering a user's question on irc, I realized that the
metasyntactic variables in "help find" are not in upper case.  As you
know this is one of my pet quests, so here is a patch to fix this.
Tested on x86-64 Fedora 29.

gdb/ChangeLog
2019-02-14  Tom Tromey  <tromey@adacore.com>

	* findcmd.c (_initialize_mem_search): Use upper case for
	metasyntactic variables.
---
 gdb/ChangeLog | 5 +++++
 gdb/findcmd.c | 6 +++---
 2 files changed, 8 insertions(+), 3 deletions(-)

-- 
2.20.1

Comments

Kevin Buettner Feb. 19, 2019, 11:54 p.m. | #1
On Thu, 14 Feb 2019 08:01:08 -0700
Tom Tromey <tromey@adacore.com> wrote:

> While answering a user's question on irc, I realized that the

> metasyntactic variables in "help find" are not in upper case.  As you

> know this is one of my pet quests, so here is a patch to fix this.

> Tested on x86-64 Fedora 29.

> 

> gdb/ChangeLog

> 2019-02-14  Tom Tromey  <tromey@adacore.com>

> 

> 	* findcmd.c (_initialize_mem_search): Use upper case for

> 	metasyntactic variables.


LGTM.

Kevin

Patch

diff --git a/gdb/findcmd.c b/gdb/findcmd.c
index cd461003d36..52f8f80aaae 100644
--- a/gdb/findcmd.c
+++ b/gdb/findcmd.c
@@ -286,9 +286,9 @@  _initialize_mem_search (void)
   add_cmd ("find", class_vars, find_command, _("\
 Search memory for a sequence of bytes.\n\
 Usage:\nfind \
-[/size-char] [/max-count] start-address, end-address, expr1 [, expr2 ...]\n\
-find [/size-char] [/max-count] start-address, +length, expr1 [, expr2 ...]\n\
-size-char is one of b,h,w,g for 8,16,32,64 bit values respectively,\n\
+[/SIZE-CHAR] [/MAX-COUNT] START-ADDRESS, END-ADDRESS, EXPR1 [, EXPR2 ...]\n\
+find [/SIZE-CHAR] [/MAX-COUNT] START-ADDRESS, +LENGTH, EXPR1 [, EXPR2 ...]\n\
+SIZE-CHAR is one of b,h,w,g for 8,16,32,64 bit values respectively,\n\
 and if not specified the size is taken from the type of the expression\n\
 in the current language.\n\
 Note that this means for example that in the case of C-like languages\n\