[testsuite] Require alias support in three tests.

Message ID D773E266-51EF-4659-81AC-1D9D093BE4D8@sandoe.co.uk
State New
Headers show
Series
  • [testsuite] Require alias support in three tests.
Related show

Commit Message

Iain Sandoe Jan. 7, 2019, 1:39 p.m.
Hi,

These three tests fail on targets without alias support,

OK to apply?

Iain


gcc/testsuite/

	* gcc.dg/Wmissing-attributes.c: Require alias support.
	* gcc.dg/attr-copy-2.c: Likewise.
	* gcc.dg/attr-copy-5.c: Likewise.
---
 gcc/testsuite/gcc.dg/Wmissing-attributes.c | 1 +
 gcc/testsuite/gcc.dg/attr-copy-2.c         | 1 +
 gcc/testsuite/gcc.dg/attr-copy-5.c         | 1 +
 3 files changed, 3 insertions(+)

-- 
2.17.1

Comments

Jeff Law Jan. 7, 2019, 7:35 p.m. | #1
On 1/7/19 6:39 AM, Iain Sandoe wrote:
> Hi,

> 

> These three tests fail on targets without alias support,

> 

> OK to apply?

> 

> Iain

> 

> 

> gcc/testsuite/

> 

> 	* gcc.dg/Wmissing-attributes.c: Require alias support.

> 	* gcc.dg/attr-copy-2.c: Likewise.

> 	* gcc.dg/attr-copy-5.c: Likewise.

Yes.  And ISTM that something like adding a missing dg-require to a test
ought to be able to move forward without requiring review.

jeff

Patch

diff --git a/gcc/testsuite/gcc.dg/Wmissing-attributes.c b/gcc/testsuite/gcc.dg/Wmissing-attributes.c
index 2a981828a2..049a4c095b 100644
--- a/gcc/testsuite/gcc.dg/Wmissing-attributes.c
+++ b/gcc/testsuite/gcc.dg/Wmissing-attributes.c
@@ -1,5 +1,6 @@ 
 /* PR middle-end/81824 - Warn for missing attributes with function aliases
    { dg-do compile }
+   { dg-require-alias "" }
    { dg-options "-Wall" } */
 
 #define ATTR(list)   __attribute__ (list)
diff --git a/gcc/testsuite/gcc.dg/attr-copy-2.c b/gcc/testsuite/gcc.dg/attr-copy-2.c
index 39e5f087de..8564811fc0 100644
--- a/gcc/testsuite/gcc.dg/attr-copy-2.c
+++ b/gcc/testsuite/gcc.dg/attr-copy-2.c
@@ -1,6 +1,7 @@ 
 /* PR middle-end/81824 - Warn for missing attributes with function aliases
    Exercise attribute copy for functions.
    { dg-do compile }
+   { dg-require-alias "" }
    { dg-options "-O2 -Wall" } */
 
 #define Assert(expr)   typedef char AssertExpr[2 * !!(expr) - 1]
diff --git a/gcc/testsuite/gcc.dg/attr-copy-5.c b/gcc/testsuite/gcc.dg/attr-copy-5.c
index b085cf968a..24cd6e7aa7 100644
--- a/gcc/testsuite/gcc.dg/attr-copy-5.c
+++ b/gcc/testsuite/gcc.dg/attr-copy-5.c
@@ -3,6 +3,7 @@ 
    copied.  Also verify that copying attribute tls_model to a non-thread
    variable triggers a warning.
    { dg-do compile }
+   { dg-require-alias "" }
    { dg-options "-Wall" }
    { dg-require-effective-target tls } */