CSKY: Modify the default target vec

Message ID f1d8bcad-2805-5871-99a5-0d8be3e09a07@c-sky.com
State New
Headers show
Series
  • CSKY: Modify the default target vec
Related show

Commit Message

Lifang Xia Dec. 28, 2018, 8:33 a.m.
Hi Alan:

     Here is a patch to modify the default target of csky in bfd.

     Could it be applied?


CSKY: Modify the default target vec

     The little endian target is more suitable.

     bfd/
             * config.bfd (csky-*-elf* | csky-*-linux*): Modify the
             default target vec

Comments

Lifang Xia Jan. 1, 2019, 5 a.m. | #1
ping.

The followings are the details:

commit e1806b9cca68837baad2d7bb73261e75d02dd983
Author: Lifang Xia <lifang_xia@c-sky.com>
Date:   Fri Dec 28 16:09:06 2018 +0800

     CSKY: Modify the default target vec

     The little endian target is more suitable.

     bfd/
             * config.bfd (csky-*-elf* | csky-*-linux*): Modify the
             default target vec

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 1396c7034e..88c1a3cf09 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2018-12-28  Lifang Xia<lifang_xia@c-sky.com>
+
+       * config.bfd (csky-*-elf* | csky-*-linux*): Modify the csky
+       default target, little endian target is more suitable.
+
  2018-12-28  Alan Modra  <amodra@gmail.com>

         PR 24015
diff --git a/bfd/config.bfd b/bfd/config.bfd
index 2bde98a819..b33e79fc3d 100644
--- a/bfd/config.bfd
+++ b/bfd/config.bfd
@@ -463,7 +463,7 @@ case "${targ}" in
      ;;

    csky-*-elf* | csky-*-linux* )
-    targ_defvec=csky_elf32_be_vec
+    targ_defvec=csky_elf32_le_vec
      targ_selvecs="csky_elf32_be_vec csky_elf32_le_vec"
      ;;


On 2018年12月28日 16:33, Lifang Xia wrote:
> Hi Alan:

>

>     Here is a patch to modify the default target of csky in bfd.

>

>     Could it be applied?

>

>

> CSKY: Modify the default target vec

>

>     The little endian target is more suitable.

>

>     bfd/

>             * config.bfd (csky-*-elf* | csky-*-linux*): Modify the

>             default target vec

>

>
Nick Clifton Jan. 3, 2019, 5:25 p.m. | #2
Hi Lifang,

> CSKY: Modify the default target vec


I am a little bit worried about this patch:

>   csky-*-elf* | csky-*-linux* )

> -    targ_defvec=csky_elf32_be_vec

> +    targ_defvec=csky_elf32_le_vec

>      targ_selvecs="csky_elf32_be_vec csky_elf32_le_vec"


Is it possible that there are users out there who are already
building toolchains with --target=csky-elf ?  If so they will
probably become confused when the default changes.

Cheers
  Nick
Lifang Xia Jan. 4, 2019, 2 a.m. | #3
Hi Nick,

Thanks for reviewing.

It is a mistake while doing the upstream. In the fact,
almost all C-SKY targets are in little endian mode.

So the csky_elf32_le_vec is more suitable.


On 2019年01月04日 01:25, Nick Clifton wrote:
> Hi Lifang,

>

>> CSKY: Modify the default target vec

> I am a little bit worried about this patch:

>

>>    csky-*-elf* | csky-*-linux* )

>> -    targ_defvec=csky_elf32_be_vec

>> +    targ_defvec=csky_elf32_le_vec

>>       targ_selvecs="csky_elf32_be_vec csky_elf32_le_vec"

> Is it possible that there are users out there who are already

> building toolchains with --target=csky-elf ?  If so they will

> probably become confused when the default changes.

>

> Cheers

>    Nick


Best regards
Lifang Xia
Nick Clifton Jan. 4, 2019, 1:57 p.m. | #4
Hi Lifang,

> It is a mistake while doing the upstream. In the fact,

> almost all C-SKY targets are in little endian mode.


Fair enough - I have applied your patch.

Cheers
  Nick

Patch

commit e1806b9cca68837baad2d7bb73261e75d02dd983
Author: Lifang Xia <lifang_xia@c-sky.com>
Date:   Fri Dec 28 16:09:06 2018 +0800

    CSKY: Modify the default target vec
    
    The little endian target is more suitable.
    
    bfd/
            * config.bfd (csky-*-elf* | csky-*-linux*): Modify the
            default target vec

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 1396c7034e..88c1a3cf09 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@ 
+2018-12-28  Lifang Xia<lifang_xia@c-sky.com>
+
+	* config.bfd (csky-*-elf* | csky-*-linux*): Modify the csky
+	default target, little endian target is more suitable.
+
 2018-12-28  Alan Modra  <amodra@gmail.com>
 
 	PR 24015
diff --git a/bfd/config.bfd b/bfd/config.bfd
index 2bde98a819..b33e79fc3d 100644
--- a/bfd/config.bfd
+++ b/bfd/config.bfd
@@ -463,7 +463,7 @@  case "${targ}" in
     ;;
 
   csky-*-elf* | csky-*-linux* )
-    targ_defvec=csky_elf32_be_vec
+    targ_defvec=csky_elf32_le_vec
     targ_selvecs="csky_elf32_be_vec csky_elf32_le_vec"
     ;;