[4/4] Revert "_bfd_mips_elf_final_link: Notify user about wrong .reginfo size"

Message ID alpine.DEB.2.00.1801312225070.4191@tp.orcam.me.uk
State New
Headers show
Series
  • LD: Support fixed-size sections some psABIs may require
Related show

Commit Message

Maciej W. Rozycki Jan. 31, 2018, 10:58 p.m.
Revert commit 58807c48a5a3 ("_bfd_mips_elf_final_link: Notify user about 
wrong .reginfo size") now that the size of the `.reginfo' section has 
been truly fixed in `_bfd_mips_elf_section_processing', meaning that the
offending condition can be asserted again.

	bfd/
	Revert
	2018-01-12  Vlad Ivanov  <vlad@ivanov.email>

	* elfxx-mips.c (_bfd_mips_elf_final_link): Notify user when
	.reginfo section has wrong size.
---
Hi,

 I will commit this change once 1/4 and 2/4 have been approved.

  Maciej
---
 bfd/elfxx-mips.c |   10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

binutils-vlad-mips-bfd-final-link-reginfo-size-revert.diff

Patch

Index: binutils/bfd/elfxx-mips.c
===================================================================
--- binutils.orig/bfd/elfxx-mips.c	2018-01-31 15:46:42.025078165 +0000
+++ binutils/bfd/elfxx-mips.c	2018-01-31 15:46:43.468115600 +0000
@@ -14385,15 +14385,7 @@  _bfd_mips_elf_final_link (bfd *abfd, str
 	    }
 
 	  /* Size has been set in _bfd_mips_elf_always_size_sections.  */
-	  if (o->size != sizeof (Elf32_External_RegInfo))
-	    {
-	      _bfd_error_handler
-		(_("%B: .reginfo section size should be %d bytes, "
-		   "actual size is %d"),
-		 abfd, sizeof (Elf32_External_RegInfo), o->size);
-
-	      return FALSE;
-	    }
+	  BFD_ASSERT(o->size == sizeof (Elf32_External_RegInfo));
 
 	  /* Skip this section later on (I don't think this currently
 	     matters, but someday it might).  */