[1/4] BFD: Remove unused SEC_HAS_GOT_REF section flag

Message ID alpine.DEB.2.00.1801310031330.4074@tp.orcam.me.uk
State New
Headers show
Series
  • LD: Support fixed-size sections some psABIs may require
Related show

Commit Message

Maciej W. Rozycki Jan. 31, 2018, 10:56 p.m.
Remove the SEC_HAS_GOT_REF section flag no longer in use since commit
a252afa4cdff ("Fix linking of PIC code on PA"),
<https://sourceware.org/ml/binutils/2003-08/msg00467.html>, to make the 
bit position available for reuse.

	bfd/
	* section.c (SEC_HAS_GOT_REF): Remove macro.
	* bfd-in2.h: Regenerate.
---
Hi,

 There's no other mention of SEC_HAS_GOT_REF left across the tree and my 
usual targets still build.  OK to apply?

  Maciej
---
 bfd/bfd-in2.h |    8 --------
 bfd/section.c |    8 --------
 2 files changed, 16 deletions(-)

binutils-bfd-sec-has-got-ref-delete.diff

Comments

Nick Clifton Feb. 1, 2018, 12:07 p.m. | #1
Hi Maciej,

> 	bfd/

> 	* section.c (SEC_HAS_GOT_REF): Remove macro.

> 	* bfd-in2.h: Regenerate.


Approved - please apply.

Cheers
  Nick

Patch

Index: binutils/bfd/bfd-in2.h
===================================================================
--- binutils.orig/bfd/bfd-in2.h	2018-01-15 17:58:04.000000000 +0000
+++ binutils/bfd/bfd-in2.h	2018-01-15 18:00:52.040872605 +0000
@@ -1324,14 +1324,6 @@  typedef struct bfd_section
   /* The section contains thread local data.  */
 #define SEC_THREAD_LOCAL                0x400
 
-  /* The section has GOT references.  This flag is only for the
-     linker, and is currently only used by the elf32-hppa back end.
-     It will be set if global offset table references were detected
-     in this section, which indicate to the linker that the section
-     contains PIC code, and must be handled specially when doing a
-     static link.  */
-#define SEC_HAS_GOT_REF                 0x800
-
   /* The section contains common symbols (symbols may be defined
      multiple times, the value of a symbol is the amount of
      space it requires, and the largest symbol value is the one
Index: binutils/bfd/section.c
===================================================================
--- binutils.orig/bfd/section.c	2018-01-15 17:58:04.000000000 +0000
+++ binutils/bfd/section.c	2018-01-15 17:58:47.240151973 +0000
@@ -221,14 +221,6 @@  CODE_FRAGMENT
 .  {* The section contains thread local data.  *}
 .#define SEC_THREAD_LOCAL                0x400
 .
-.  {* The section has GOT references.  This flag is only for the
-.     linker, and is currently only used by the elf32-hppa back end.
-.     It will be set if global offset table references were detected
-.     in this section, which indicate to the linker that the section
-.     contains PIC code, and must be handled specially when doing a
-.     static link.  *}
-.#define SEC_HAS_GOT_REF                 0x800
-.
 .  {* The section contains common symbols (symbols may be defined
 .     multiple times, the value of a symbol is the amount of
 .     space it requires, and the largest symbol value is the one