[committed] MIPS/GAS: Correct `mips-*-sysv4*' target emulation configuration

Message ID alpine.DEB.2.00.1801221543490.20647@tp.orcam.me.uk
State New
Headers show
Series
  • [committed] MIPS/GAS: Correct `mips-*-sysv4*' target emulation configuration
Related show

Commit Message

Maciej W. Rozycki Jan. 26, 2018, 11:06 p.m.
Use `mips-*-sysv4*' rather than `mips-*-sysv4*MP*' to match the system
type for System V Release 4 MIPS targets, removing a GAS target
selection failure:

Assembler messages:
Fatal error: selected target format 'elf32-bigmips' unknown

on any assembly attempt with `mips-sysv4' and equivalent target
configurations.  These would typically be called `mips-sni-sysv4'
(Sinix) vs `mips-dde-sysv4.2MP' (Supermax).

This corrects commit 8614eeee67f9 ("Traditional MIPS patches"),
<https://sourceware.org/ml/binutils/2000-07/msg00018.html>, making GAS
target selection match commit dd745cfae548 ("Traditional MIPS patches"),
<https://sourceware.org/ml/binutils/2000-07/msg00018.html>, and commit
3548145dcbf6 ("Traditional MIPS patches"),
<https://sourceware.org/ml/binutils/2000-07/msg00018.html>, which added
support for these targets to BFD and LD respectively.

	gas/
	* configure.tgt: Use `mips-*-sysv4*' rather than
	`mips-*-sysv4*MP*'.
---
Hi,

 Obviously nobody has ever bothered to verify that this configuration 
works (and the original patches weren't even posted; only ChangeLogs were) 
so interest must have been inexistent since forever, but correcting the 
configuration is clearly cheaper than trying to extract all the necessary 
bits to remove it and with the fix in place test suite results are close 
to those for say `mips-linux' target, with:

mips-sysv4  FAIL: MIPS16 reloc
mips-sysv4  FAIL: MIPS16 reloc 2
mips-sysv4  FAIL: Build pr22649-2c.so
mips-sysv4  FAIL: Build pr22649-2d.so
mips-sysv4  FAIL: DT_TEXTREL map file warning

being the only failures.  Committed then.

  Maciej

---
 gas/configure.tgt |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

binutils-mips-gas-config-sysv4.diff

Patch

Index: binutils/gas/configure.tgt
===================================================================
--- binutils.orig/gas/configure.tgt	2018-01-18 16:25:01.000000000 +0000
+++ binutils/gas/configure.tgt	2018-01-18 23:33:06.690610803 +0000
@@ -345,7 +345,7 @@  case ${generic_target} in
   mips*-*-linux*)			fmt=elf em=tmips ;;
   mips*-*-freebsd* | mips*-*-kfreebsd*-gnu)
 					fmt=elf em=freebsd ;;
-  mips-*-sysv4*MP* | mips-*-gnu*)	fmt=elf em=tmips ;;
+  mips-*-sysv4* | mips-*-gnu*)		fmt=elf em=tmips ;;
   mips*-sde-elf* | mips*-mti-elf* | mips*-img-elf*)
 					fmt=elf em=tmips ;;
   mips-*-elf*)				fmt=elf ;;