[0/5] Some minor dwz-handling improvements & cleanups

Message ID 20210221031647.949270-1-tom@tromey.com
Headers show
Series
  • Some minor dwz-handling improvements & cleanups
Related show

Message

Tom Tromey Feb. 21, 2021, 3:16 a.m.
I was looking at adding support for DWARF 5's equivalent to
.gnu_debugaltlink, and found that I could provoke a gdb crash.  In
particular, if gdb tries to process a form requiring a "dwz" file, but
no .gnu_debugaltlink section exists, then that will cause a failure.
See patch #3 for some more info on this.

While fixing this, I found a number of small cleanups that made the
result a bit prettier.  There are more like this that are possible,
for example basically none of the DWARF code should be in symfile.h.

Let me know what you think.

Tom

Comments

Tom Tromey March 6, 2021, 4:28 p.m. | #1
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:


Tom> I was looking at adding support for DWARF 5's equivalent to
Tom> .gnu_debugaltlink, and found that I could provoke a gdb crash.  In
Tom> particular, if gdb tries to process a form requiring a "dwz" file, but
Tom> no .gnu_debugaltlink section exists, then that will cause a failure.
Tom> See patch #3 for some more info on this.

Tom> While fixing this, I found a number of small cleanups that made the
Tom> result a bit prettier.  There are more like this that are possible,
Tom> for example basically none of the DWARF code should be in symfile.h.

I'm checking these in now.

Tom