[0/7] Fix and cleanups in jit.c

Message ID 20191213060323.1799590-1-simon.marchi@polymtl.ca
Headers show
Series
  • Fix and cleanups in jit.c
Related show

Message

Simon Marchi Dec. 13, 2019, 6:03 a.m.
Patch 1 fixes a bug I found while playing with the jit debug info reader
interface.

The other patches apply some C++ magic to make the code (IMO) easier to
work with.

Simon Marchi (7):
  Fix double-free when creating more than one block in JIT debug info
    reader
  jit: make gdb_object::symtabs a vector
  jit: c++-ify gdb_symtab
  jit: make gdb_symtab::blocks a vector
  jit: make gdb_object::symtabs a vector of unique_ptr
  jit: c++-ify gdb_block
  jit: make gdb_symtab::blocks a vector of unique_ptr

 gdb/jit.c                             | 184 +++++++++-----------------
 gdb/testsuite/gdb.base/jit-reader.exp |  14 +-
 gdb/testsuite/gdb.base/jithost.c      |  45 +++++--
 gdb/testsuite/gdb.base/jithost.h      |  15 ++-
 gdb/testsuite/gdb.base/jitreader.c    |  34 +++--
 5 files changed, 139 insertions(+), 153 deletions(-)

-- 
2.24.1

Comments

Tom Tromey Dec. 13, 2019, 9:19 p.m. | #1
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:


Simon> Patch 1 fixes a bug I found while playing with the jit debug info reader
Simon> interface.

Simon> The other patches apply some C++ magic to make the code (IMO) easier to
Simon> work with.

I read through these.  I just had one comment but I also agree with the
comments from the other reviews -- I just didn't have anything to add there.

thanks,
Tom