[00/15] Enable -Wmissing-declarations diagnostic

Message ID 20191125052655.22696-1-simon.marchi@efficios.com
Headers show
Series
  • Enable -Wmissing-declarations diagnostic
Related show

Message

Simon Marchi Nov. 25, 2019, 5:26 a.m.
This series does a bunch of fixes that lead to enabling
-Wmissing-declarations.  In my experience (and as shown by the fixes
done by this series), this warning is helpful to detect few classes of
buglets, from forgetting to include foo.h in foo.c, to having a function
that should be static be not static and having declarations not in sync
with definitions (although this one is less likely to be a problem with
C++).

Simon Marchi (15):
  Add back declarations for _initialize functions
  Include aarch32-tdep.h in aarch32-tdep.c
  Add missing includes in dwarf-index-write.c and mi/mi-interp.c
  Remove unused function set_gdb_completion_word_break_characters
  Make a bunch of functions static
  Remove dict_empty/mdict_empty
  Remove unused overload of exit_inferior_silent
  Remove info_terminal_command declaration, make definition static
  Add declaration to python init func
  Remove unused rbreak_command_wrapper and other declarations
  Remove declaration of tui_set_var_cmd, make definition static
  Make functions static in unittests
  Remove simulator_command declaration, make static
  Fix declaration of sparc_xfer_wcookie
  Enable -Wmissing-declarations diagnostic

 gdb/aarch32-tdep.c                            |  3 ++
 gdb/aarch32-tdep.h                            |  2 ++
 gdb/aarch64-fbsd-nat.c                        |  3 +-
 gdb/aarch64-fbsd-tdep.c                       |  3 +-
 gdb/aarch64-linux-nat.c                       |  3 +-
 gdb/aarch64-linux-tdep.c                      |  3 +-
 gdb/aarch64-newlib-tdep.c                     |  3 +-
 gdb/aarch64-tdep.c                            |  3 +-
 gdb/ada-exp.y                                 |  3 +-
 gdb/ada-lang.c                                |  3 +-
 gdb/ada-tasks.c                               |  3 +-
 gdb/agent.c                                   |  3 +-
 gdb/aix-thread.c                              |  3 +-
 gdb/alpha-bsd-nat.c                           |  3 +-
 gdb/alpha-linux-nat.c                         |  3 +-
 gdb/alpha-linux-tdep.c                        |  3 +-
 gdb/alpha-nbsd-tdep.c                         |  3 +-
 gdb/alpha-obsd-tdep.c                         |  3 +-
 gdb/alpha-tdep.c                              |  3 +-
 gdb/amd64-darwin-tdep.c                       |  3 +-
 gdb/amd64-dicos-tdep.c                        |  3 +-
 gdb/amd64-fbsd-nat.c                          |  3 +-
 gdb/amd64-fbsd-tdep.c                         |  3 +-
 gdb/amd64-linux-nat.c                         |  3 +-
 gdb/amd64-linux-tdep.c                        |  3 +-
 gdb/amd64-nbsd-nat.c                          |  3 +-
 gdb/amd64-nbsd-tdep.c                         |  3 +-
 gdb/amd64-obsd-nat.c                          |  3 +-
 gdb/amd64-obsd-tdep.c                         |  3 +-
 gdb/amd64-sol2-tdep.c                         |  3 +-
 gdb/amd64-tdep.c                              |  3 +-
 gdb/amd64-windows-nat.c                       |  3 +-
 gdb/amd64-windows-tdep.c                      |  3 +-
 gdb/annotate.c                                |  3 +-
 gdb/arc-newlib-tdep.c                         |  3 +-
 gdb/arc-tdep.c                                |  9 +++---
 gdb/arch-utils.c                              |  3 +-
 gdb/arm-fbsd-nat.c                            |  3 +-
 gdb/arm-fbsd-tdep.c                           |  3 +-
 gdb/arm-linux-nat.c                           |  3 +-
 gdb/arm-linux-tdep.c                          |  3 +-
 gdb/arm-nbsd-nat.c                            |  3 +-
 gdb/arm-nbsd-tdep.c                           |  3 +-
 gdb/arm-obsd-tdep.c                           |  3 +-
 gdb/arm-pikeos-tdep.c                         |  3 +-
 gdb/arm-symbian-tdep.c                        |  3 +-
 gdb/arm-tdep.c                                |  3 +-
 gdb/arm-wince-tdep.c                          |  3 +-
 gdb/auto-load.c                               |  3 +-
 gdb/auxv.c                                    |  3 +-
 gdb/avr-tdep.c                                |  3 +-
 gdb/ax-gdb.c                                  |  3 +-
 gdb/bfin-linux-tdep.c                         |  3 +-
 gdb/bfin-tdep.c                               |  3 +-
 gdb/break-catch-sig.c                         |  3 +-
 gdb/break-catch-syscall.c                     |  3 +-
 gdb/break-catch-throw.c                       |  3 +-
 gdb/breakpoint.c                              |  3 +-
 gdb/breakpoint.h                              |  3 --
 gdb/bsd-uthread.c                             |  3 +-
 gdb/btrace.c                                  |  3 +-
 gdb/charset.c                                 |  3 +-
 gdb/cli/cli-cmds.c                            |  3 +-
 gdb/cli/cli-dump.c                            |  3 +-
 gdb/cli/cli-interp.c                          |  3 +-
 gdb/cli/cli-logging.c                         |  3 +-
 gdb/cli/cli-script.c                          |  3 +-
 gdb/cli/cli-style.c                           |  1 +
 gdb/coff-pe-read.c                            |  3 +-
 gdb/coffread.c                                |  3 +-
 gdb/compile/compile-cplus-types.c             |  1 +
 gdb/compile/compile.c                         |  3 +-
 gdb/complaints.c                              |  3 +-
 gdb/completer.c                               | 20 ++----------
 gdb/configure                                 |  3 +-
 gdb/copying.c                                 |  3 +-
 gdb/corefile.c                                |  3 +-
 gdb/corelow.c                                 |  3 +-
 gdb/cp-abi.c                                  |  3 +-
 gdb/cp-namespace.c                            |  3 +-
 gdb/cp-support.c                              |  5 +--
 gdb/cp-valprint.c                             |  3 +-
 gdb/cris-linux-tdep.c                         |  3 +-
 gdb/cris-tdep.c                               |  3 +-
 gdb/csky-linux-tdep.c                         |  5 +--
 gdb/csky-tdep.c                               |  3 +-
 gdb/ctfread.c                                 |  3 +-
 gdb/d-lang.c                                  |  3 +-
 gdb/darwin-nat-info.c                         |  3 +-
 gdb/darwin-nat.c                              |  1 +
 gdb/dbxread.c                                 |  3 +-
 gdb/dcache.c                                  |  3 +-
 gdb/dictionary.c                              | 32 +++----------------
 gdb/dictionary.h                              |  4 ---
 gdb/disasm-selftests.c                        |  3 +-
 gdb/disasm.c                                  |  3 +-
 gdb/dtrace-probe.c                            |  3 +-
 gdb/dummy-frame.c                             |  3 +-
 gdb/dwarf-index-cache.c                       |  1 +
 gdb/dwarf-index-write.c                       |  3 ++
 gdb/dwarf2-frame-tailcall.c                   |  3 +-
 gdb/dwarf2-frame.c                            |  3 +-
 gdb/dwarf2expr.c                              |  3 +-
 gdb/dwarf2loc.c                               |  3 +-
 gdb/dwarf2read.c                              |  3 +-
 gdb/elfread.c                                 |  3 +-
 gdb/exec.c                                    |  3 +-
 gdb/extension.c                               |  3 +-
 gdb/f-lang.c                                  |  6 ++--
 gdb/f-valprint.c                              |  3 +-
 gdb/fbsd-nat.c                                |  3 +-
 gdb/fbsd-tdep.c                               |  3 +-
 gdb/filesystem.c                              |  3 +-
 gdb/findcmd.c                                 |  3 +-
 gdb/findvar.c                                 |  3 +-
 gdb/fork-child.c                              |  3 +-
 gdb/frame-base.c                              |  3 +-
 gdb/frame-unwind.c                            |  3 +-
 gdb/frame.c                                   |  3 +-
 gdb/frv-linux-tdep.c                          |  3 +-
 gdb/frv-tdep.c                                |  3 +-
 gdb/ft32-tdep.c                               |  3 +-
 gdb/gcore.c                                   |  3 +-
 gdb/gdb-demangle.c                            |  3 +-
 gdb/gdb_bfd.c                                 |  3 +-
 gdb/gdbarch-selftests.c                       |  3 +-
 gdb/gdbarch.c                                 |  3 +-
 gdb/gdbtypes.c                                |  3 +-
 gdb/gnu-nat.c                                 |  3 +-
 gdb/gnu-v2-abi.c                              |  3 +-
 gdb/gnu-v3-abi.c                              |  3 +-
 gdb/go-lang.c                                 |  3 +-
 gdb/go32-nat.c                                |  3 +-
 gdb/guile/guile.c                             |  3 +-
 gdb/h8300-tdep.c                              |  3 +-
 gdb/hppa-linux-nat.c                          |  3 +-
 gdb/hppa-linux-tdep.c                         |  3 +-
 gdb/hppa-nbsd-nat.c                           |  3 +-
 gdb/hppa-nbsd-tdep.c                          |  3 +-
 gdb/hppa-obsd-nat.c                           |  3 +-
 gdb/hppa-obsd-tdep.c                          |  3 +-
 gdb/hppa-tdep.c                               |  5 +--
 gdb/i386-bsd-nat.c                            |  3 +-
 gdb/i386-cygwin-tdep.c                        |  3 +-
 gdb/i386-darwin-nat.c                         |  3 +-
 gdb/i386-darwin-tdep.c                        |  3 +-
 gdb/i386-dicos-tdep.c                         |  3 +-
 gdb/i386-fbsd-nat.c                           |  3 +-
 gdb/i386-fbsd-tdep.c                          |  3 +-
 gdb/i386-gnu-nat.c                            |  3 +-
 gdb/i386-gnu-tdep.c                           |  3 +-
 gdb/i386-go32-tdep.c                          |  1 +
 gdb/i386-linux-nat.c                          |  3 +-
 gdb/i386-linux-tdep.c                         |  3 +-
 gdb/i386-nbsd-nat.c                           |  3 +-
 gdb/i386-nbsd-tdep.c                          |  3 +-
 gdb/i386-nto-tdep.c                           |  3 +-
 gdb/i386-obsd-nat.c                           |  3 +-
 gdb/i386-obsd-tdep.c                          |  3 +-
 gdb/i386-sol2-nat.c                           |  3 +-
 gdb/i386-sol2-tdep.c                          |  3 +-
 gdb/i386-tdep.c                               |  5 +--
 gdb/i386-windows-nat.c                        |  3 +-
 gdb/ia64-libunwind-tdep.c                     |  3 +-
 gdb/ia64-linux-nat.c                          |  3 +-
 gdb/ia64-linux-tdep.c                         |  3 +-
 gdb/ia64-tdep.c                               |  3 +-
 gdb/ia64-vms-tdep.c                           |  3 +-
 gdb/infcall.c                                 |  3 +-
 gdb/infcmd.c                                  |  3 +-
 gdb/inferior.c                                |  8 -----
 gdb/inferior.h                                |  2 --
 gdb/inflow.c                                  |  5 +--
 gdb/infrun.c                                  |  3 +-
 gdb/interps.c                                 |  3 +-
 gdb/iq2000-tdep.c                             |  3 +-
 gdb/jit.c                                     |  3 +-
 gdb/language.c                                |  3 +-
 gdb/linux-fork.c                              |  3 +-
 gdb/linux-nat.c                               |  3 +-
 gdb/linux-tdep.c                              |  3 +-
 gdb/linux-thread-db.c                         |  3 +-
 gdb/lm32-tdep.c                               |  3 +-
 gdb/m2-lang.c                                 |  3 +-
 gdb/m32c-tdep.c                               |  3 +-
 gdb/m32r-linux-nat.c                          |  3 +-
 gdb/m32r-linux-tdep.c                         |  3 +-
 gdb/m32r-tdep.c                               |  3 +-
 gdb/m68hc11-tdep.c                            |  3 +-
 gdb/m68k-bsd-nat.c                            |  3 +-
 gdb/m68k-bsd-tdep.c                           |  3 +-
 gdb/m68k-linux-nat.c                          |  3 +-
 gdb/m68k-linux-tdep.c                         |  3 +-
 gdb/m68k-tdep.c                               |  3 +-
 gdb/machoread.c                               |  3 +-
 gdb/macrocmd.c                                |  3 +-
 gdb/macroscope.c                              |  3 +-
 gdb/maint-test-options.c                      |  1 +
 gdb/maint-test-settings.c                     |  3 +-
 gdb/maint.c                                   |  3 +-
 gdb/mdebugread.c                              |  3 +-
 gdb/memattr.c                                 |  3 +-
 gdb/mep-tdep.c                                |  3 +-
 gdb/mi/mi-cmd-env.c                           |  3 +-
 gdb/mi/mi-cmds.c                              |  3 +-
 gdb/mi/mi-interp.c                            |  6 +++-
 gdb/mi/mi-main.c                              |  3 +-
 gdb/microblaze-linux-tdep.c                   |  3 +-
 gdb/microblaze-tdep.c                         |  3 +-
 gdb/mips-fbsd-nat.c                           |  3 +-
 gdb/mips-fbsd-tdep.c                          |  3 +-
 gdb/mips-linux-nat.c                          |  3 +-
 gdb/mips-linux-tdep.c                         |  3 +-
 gdb/mips-nbsd-nat.c                           |  3 +-
 gdb/mips-nbsd-tdep.c                          |  3 +-
 gdb/mips-sde-tdep.c                           |  3 +-
 gdb/mips-tdep.c                               |  3 +-
 gdb/mips64-obsd-nat.c                         |  3 +-
 gdb/mips64-obsd-tdep.c                        |  3 +-
 gdb/mipsread.c                                |  3 +-
 gdb/mn10300-linux-tdep.c                      |  3 +-
 gdb/mn10300-tdep.c                            |  3 +-
 gdb/moxie-tdep.c                              |  3 +-
 gdb/msp430-tdep.c                             |  3 +-
 gdb/nds32-tdep.c                              |  3 +-
 gdb/nios2-linux-tdep.c                        |  3 +-
 gdb/nios2-tdep.c                              |  3 +-
 gdb/nto-procfs.c                              |  3 +-
 gdb/objc-lang.c                               |  3 +-
 gdb/observable.c                              |  3 +-
 gdb/opencl-lang.c                             |  3 +-
 gdb/or1k-linux-tdep.c                         |  3 +-
 gdb/or1k-tdep.c                               |  3 +-
 gdb/osabi.c                                   |  3 +-
 gdb/osdata.c                                  |  3 +-
 gdb/p-valprint.c                              |  3 +-
 gdb/parse.c                                   |  5 +--
 gdb/ppc-fbsd-nat.c                            |  3 +-
 gdb/ppc-fbsd-tdep.c                           |  3 +-
 gdb/ppc-linux-nat.c                           |  3 +-
 gdb/ppc-linux-tdep.c                          |  5 +--
 gdb/ppc-nbsd-nat.c                            |  3 +-
 gdb/ppc-nbsd-tdep.c                           |  3 +-
 gdb/ppc-obsd-nat.c                            |  3 +-
 gdb/ppc-obsd-tdep.c                           |  3 +-
 gdb/printcmd.c                                |  3 +-
 gdb/probe.c                                   |  3 +-
 gdb/proc-api.c                                |  3 +-
 gdb/proc-events.c                             |  3 +-
 gdb/proc-service.c                            |  3 +-
 gdb/procfs.c                                  |  3 +-
 gdb/producer.c                                |  1 +
 gdb/psymtab.c                                 |  3 +-
 gdb/python/python.c                           |  4 ++-
 gdb/ravenscar-thread.c                        |  1 +
 gdb/record-btrace.c                           |  3 +-
 gdb/record-full.c                             |  3 +-
 gdb/record.c                                  |  3 +-
 gdb/regcache-dump.c                           |  3 +-
 gdb/regcache.c                                |  3 +-
 gdb/reggroups.c                               |  3 +-
 gdb/remote-notif.c                            |  3 +-
 gdb/remote-sim.c                              |  7 ++--
 gdb/remote.c                                  |  7 ++--
 gdb/reverse.c                                 |  3 +-
 gdb/riscv-fbsd-nat.c                          |  3 +-
 gdb/riscv-fbsd-tdep.c                         |  3 +-
 gdb/riscv-linux-nat.c                         |  3 +-
 gdb/riscv-linux-tdep.c                        |  3 +-
 gdb/riscv-tdep.c                              |  3 +-
 gdb/rl78-tdep.c                               |  3 +-
 gdb/rs6000-aix-tdep.c                         |  5 +--
 gdb/rs6000-lynx178-tdep.c                     |  3 +-
 gdb/rs6000-nat.c                              |  3 +-
 gdb/rs6000-tdep.c                             |  3 +-
 gdb/rust-exp.y                                |  3 +-
 gdb/rx-tdep.c                                 |  3 +-
 gdb/s12z-tdep.c                               |  5 +--
 gdb/s390-linux-nat.c                          |  3 +-
 gdb/s390-linux-tdep.c                         |  3 +-
 gdb/s390-tdep.c                               |  3 +-
 gdb/score-tdep.c                              |  3 +-
 gdb/ser-go32.c                                |  3 +-
 gdb/ser-mingw.c                               |  3 +-
 gdb/ser-pipe.c                                |  3 +-
 gdb/ser-tcp.c                                 |  3 +-
 gdb/ser-uds.c                                 |  3 +-
 gdb/ser-unix.c                                |  3 +-
 gdb/serial.c                                  |  3 +-
 gdb/sh-linux-tdep.c                           |  3 +-
 gdb/sh-nbsd-nat.c                             |  3 +-
 gdb/sh-nbsd-tdep.c                            |  3 +-
 gdb/sh-tdep.c                                 |  3 +-
 gdb/skip.c                                    |  3 +-
 gdb/sol-thread.c                              |  3 +-
 gdb/solib-aix.c                               |  3 +-
 gdb/solib-darwin.c                            |  3 +-
 gdb/solib-dsbt.c                              |  3 +-
 gdb/solib-frv.c                               |  3 +-
 gdb/solib-svr4.c                              |  3 +-
 gdb/solib-target.c                            |  3 +-
 gdb/solib.c                                   |  3 +-
 gdb/source-cache.c                            |  1 +
 gdb/source.c                                  |  5 +--
 gdb/sparc-linux-nat.c                         |  3 +-
 gdb/sparc-linux-tdep.c                        |  3 +-
 gdb/sparc-nat.c                               |  5 +--
 gdb/sparc-nbsd-nat.c                          |  3 +-
 gdb/sparc-nbsd-tdep.c                         |  3 +-
 gdb/sparc-obsd-tdep.c                         |  3 +-
 gdb/sparc-sol2-tdep.c                         |  3 +-
 gdb/sparc-tdep.c                              |  3 +-
 gdb/sparc64-fbsd-nat.c                        |  3 +-
 gdb/sparc64-fbsd-tdep.c                       |  3 +-
 gdb/sparc64-linux-nat.c                       |  3 +-
 gdb/sparc64-linux-tdep.c                      |  5 +--
 gdb/sparc64-nat.c                             |  3 +-
 gdb/sparc64-nbsd-nat.c                        |  3 +-
 gdb/sparc64-nbsd-tdep.c                       |  3 +-
 gdb/sparc64-obsd-nat.c                        |  3 +-
 gdb/sparc64-obsd-tdep.c                       |  3 +-
 gdb/sparc64-sol2-tdep.c                       |  3 +-
 gdb/sparc64-tdep.c                            |  3 +-
 gdb/stabsread.c                               |  3 +-
 gdb/stack.c                                   |  5 +--
 gdb/stap-probe.c                              |  3 +-
 gdb/std-regs.c                                |  3 +-
 gdb/symfile-debug.c                           |  3 +-
 gdb/symfile-mem.c                             |  3 +-
 gdb/symfile.c                                 |  3 +-
 gdb/symmisc.c                                 |  3 +-
 gdb/symtab.c                                  | 11 ++-----
 gdb/target-dcache.c                           |  3 +-
 gdb/target-descriptions.c                     |  3 +-
 gdb/thread.c                                  |  3 +-
 gdb/tic6x-linux-tdep.c                        |  3 +-
 gdb/tic6x-tdep.c                              |  3 +-
 gdb/tilegx-linux-nat.c                        |  3 +-
 gdb/tilegx-linux-tdep.c                       |  3 +-
 gdb/tilegx-tdep.c                             |  3 +-
 gdb/tracectf.c                                |  3 +-
 gdb/tracefile-tfile.c                         |  3 +-
 gdb/tracefile.c                               |  3 +-
 gdb/tracepoint.c                              |  3 +-
 gdb/tui/tui-hooks.c                           |  3 +-
 gdb/tui/tui-interp.c                          |  3 +-
 gdb/tui/tui-layout.c                          |  3 +-
 gdb/tui/tui-regs.c                            |  3 +-
 gdb/tui/tui-stack.c                           |  3 +-
 gdb/tui/tui-win.c                             |  6 ++--
 gdb/tui/tui-win.h                             |  3 --
 gdb/tui/tui.c                                 |  3 +-
 gdb/typeprint.c                               |  3 +-
 gdb/ui-style.c                                |  1 +
 gdb/unittests/array-view-selftests.c          |  3 +-
 gdb/unittests/basic_string_view/capacity/1.cc |  6 ++--
 .../basic_string_view/cons/char/1.cc          |  8 ++---
 .../basic_string_view/cons/char/2.cc          |  8 ++---
 .../basic_string_view/cons/char/3.cc          |  8 ++---
 .../element_access/char/1.cc                  |  8 ++---
 .../element_access/char/empty.cc              |  4 +--
 .../element_access/char/front_back.cc         |  8 ++---
 .../basic_string_view/inserters/char/2.cc     |  8 ++---
 .../modifiers/remove_prefix/char/1.cc         |  8 ++---
 .../modifiers/remove_suffix/char/1.cc         |  8 ++---
 .../modifiers/swap/char/1.cc                  |  4 +--
 .../operations/compare/char/1.cc              |  8 ++---
 .../operations/compare/char/13650.cc          |  6 ++--
 .../operations/copy/char/1.cc                 |  8 ++---
 .../operations/data/char/1.cc                 |  8 ++---
 .../operations/find/char/1.cc                 |  8 ++---
 .../operations/find/char/2.cc                 |  8 ++---
 .../operations/find/char/3.cc                 |  8 ++---
 .../operations/find/char/4.cc                 |  6 ++--
 .../operations/rfind/char/1.cc                |  8 ++---
 .../operations/rfind/char/2.cc                |  8 ++---
 .../operations/rfind/char/3.cc                |  9 +++---
 .../operations/substr/char/1.cc               |  8 ++---
 .../basic_string_view/operators/char/2.cc     |  6 ++--
 gdb/unittests/child-path-selftests.c          |  1 +
 gdb/unittests/cli-utils-selftests.c           |  1 +
 gdb/unittests/common-utils-selftests.c        |  1 +
 gdb/unittests/copy_bitwise-selftests.c        |  1 +
 gdb/unittests/environ-selftests.c             |  1 +
 gdb/unittests/format_pieces-selftests.c       |  1 +
 gdb/unittests/function-view-selftests.c       |  1 +
 gdb/unittests/help-doc-selftests.c            |  1 +
 gdb/unittests/lookup_name_info-selftests.c    |  1 +
 gdb/unittests/memory-map-selftests.c          |  1 +
 gdb/unittests/memrange-selftests.c            |  1 +
 gdb/unittests/mkdir-recursive-selftests.c     |  1 +
 gdb/unittests/observable-selftests.c          |  1 +
 gdb/unittests/offset-type-selftests.c         |  1 +
 gdb/unittests/optional-selftests.c            |  1 +
 gdb/unittests/optional/assignment/1.cc        |  3 +-
 gdb/unittests/optional/assignment/2.cc        |  3 +-
 gdb/unittests/optional/assignment/3.cc        |  3 +-
 gdb/unittests/optional/assignment/4.cc        |  3 +-
 gdb/unittests/optional/assignment/5.cc        |  3 +-
 gdb/unittests/optional/assignment/6.cc        |  3 +-
 gdb/unittests/optional/assignment/7.cc        |  3 +-
 gdb/unittests/optional/cons/copy.cc           |  3 +-
 gdb/unittests/optional/cons/default.cc        |  3 +-
 gdb/unittests/optional/cons/move.cc           |  3 +-
 gdb/unittests/optional/cons/value.cc          |  3 +-
 gdb/unittests/optional/in_place.cc            |  3 +-
 gdb/unittests/optional/observers/1.cc         |  3 +-
 gdb/unittests/optional/observers/2.cc         |  3 +-
 .../parse-connection-spec-selftests.c         |  1 +
 gdb/unittests/rsp-low-selftests.c             |  1 +
 gdb/unittests/scoped_fd-selftests.c           |  1 +
 gdb/unittests/scoped_mmap-selftests.c         |  1 +
 gdb/unittests/scoped_restore-selftests.c      |  1 +
 gdb/unittests/string_view-selftests.c         |  1 +
 gdb/unittests/style-selftests.c               |  1 +
 gdb/unittests/tracepoint-selftests.c          |  1 +
 gdb/unittests/unpack-selftests.c              |  1 +
 gdb/unittests/utils-selftests.c               |  1 +
 gdb/unittests/vec-utils-selftests.c           |  1 +
 gdb/unittests/xml-utils-selftests.c           |  1 +
 gdb/user-regs.c                               |  3 +-
 gdb/utils.c                                   |  3 +-
 gdb/v850-tdep.c                               |  3 +-
 gdb/valops.c                                  |  3 +-
 gdb/valprint.c                                |  3 +-
 gdb/value.c                                   |  3 +-
 gdb/varobj.c                                  |  3 +-
 gdb/vax-bsd-nat.c                             |  3 +-
 gdb/vax-nbsd-tdep.c                           |  3 +-
 gdb/vax-tdep.c                                |  3 +-
 gdb/warning.m4                                |  3 +-
 gdb/windows-nat.c                             |  9 ++++--
 gdb/windows-tdep.c                            |  3 +-
 gdb/x86-bsd-nat.c                             |  1 +
 gdb/x86-linux-nat.c                           |  1 +
 gdb/xcoffread.c                               |  3 +-
 gdb/xml-support.c                             |  4 ++-
 gdb/xstormy16-tdep.c                          |  3 +-
 gdb/xtensa-linux-nat.c                        |  3 +-
 gdb/xtensa-linux-tdep.c                       |  3 +-
 gdb/xtensa-tdep.c                             |  3 +-
 441 files changed, 910 insertions(+), 555 deletions(-)

-- 
2.24.0

Comments

Tom Tromey Nov. 25, 2019, 10:08 p.m. | #1
>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:


Simon> This series does a bunch of fixes that lead to enabling
Simon> -Wmissing-declarations.  In my experience (and as shown by the fixes
Simon> done by this series), this warning is helpful to detect few classes of
Simon> buglets, from forgetting to include foo.h in foo.c, to having a function
Simon> that should be static be not static and having declarations not in sync
Simon> with definitions (although this one is less likely to be a problem with
Simon> C++).

I read through this series and it all looked good to me.  Like you, I
think this is a good idea.

Patch #1 is maybe mildly unfortunate, but that seems like a small price
to pay.

I sent one comment to the final patch.

thanks,
Tom