[0/5] pipe command completer, and string options

Message ID 20190627191427.20742-1-palves@redhat.com
Headers show
Series
  • pipe command completer, and string options
Related show

Message

Pedro Alves June 27, 2019, 7:14 p.m.
Tromey noticed that the "pipe" command doesn't have a completer.
Initially I said I wasn't planning on looking at it, thinking that all
the building blocks were already in place.  But I quickly realized
that there's one piece missing -- string options...  So I took a stab
at implementing it.  Of course, lucky me, I ran into other issues and
latent bugs, now all addressed...

Pedro Alves (5):
  Fix test_gdb_complete_tab_multiple race
  Make gdb::option::complete_options save processed arguments too
  Teach gdb::option about string options
  Fix latent bug in test_gdb_complete_cmd_multiple
  pipe command completer

 gdb/cli/cli-cmds.c                       |  92 +++++++++++++--
 gdb/cli/cli-option.c                     | 157 ++++++++++++++++++++-----
 gdb/cli/cli-option.h                     |  21 ++++
 gdb/cli/cli-utils.c                      |   7 +-
 gdb/maint-test-options.c                 | 134 ++++++++++++++--------
 gdb/testsuite/gdb.base/options.exp       | 190 +++++++++++++++++++++++--------
 gdb/testsuite/gdb.base/shell.exp         |  47 +++++++-
 gdb/testsuite/lib/completion-support.exp |  11 +-
 8 files changed, 522 insertions(+), 137 deletions(-)

-- 
2.14.5

Comments

Tom Tromey June 28, 2019, 3:16 p.m. | #1
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:


Pedro> Tromey noticed that the "pipe" command doesn't have a completer.
Pedro> Initially I said I wasn't planning on looking at it, thinking that all
Pedro> the building blocks were already in place.  But I quickly realized
Pedro> that there's one piece missing -- string options...  So I took a stab
Pedro> at implementing it.  Of course, lucky me, I ran into other issues and
Pedro> latent bugs, now all addressed...

I read through these and sent whatever comments I had.
Thanks again for doing this.

Tom