[00/25] Make use of default gdbarch methods for some more targets

Message ID cover.1553721864.git.andrew.burgess@embecosm.com
Headers show
Series
  • Make use of default gdbarch methods for some more targets
Related show

Message

Andrew Burgess March 27, 2019, 9:33 p.m.
This series follows on from this one:

  https://www.sourceware.org/ml/gdb-patches/2018-12/msg00358.html

This series removes the dummy_id, unwind_pc, and unwind_sp gdbarch
methods from some targets in cases where it seems obvious that the
default method, and the method being deleted are the same.

I've CC'd target maintainers where I can find any in the hope people
might test their own target, however, not every target has an obvious
maintainer, so some are going to rely on review only.

This series addresses all of the targets not addressed in the first
round.

A final note, all of these patches are independent, each should apply
cleanly without the preceding patches, so feel free to review any that
are of interest, you don't need to apply/review the entire series.

Thanks,
Andrew

--

Andrew Burgess (25):
  gdb/iq2000: Use default gdbarch methods where possible
  gdb/lm32: Use default gdbarch methods where possible
  gdb/m32c: Use default gdbarch methods where possible
  gdb/m32r: Use default gdbarch methods where possible
  gdb/m68hc11: Use default gdbarch methods where possible
  gdb/mep: Use default gdbarch methods where possible
  gdb/mips: Use default gdbarch methods where possible
  gdb/mn10300: Use default gdbarch methods where possible
  gdb/moxie: Use default gdbarch methods where possible
  gdb/msp430: Use default gdbarch methods where possible
  gdb/nds32: Use default gdbarch methods where possible
  gdb/nios2: Use default gdbarch methods where possible
  gdb/or1k: Use default gdbarch methods where possible
  gdb/rs6000: Use default gdbarch methods where possible
  gdb/rx: Use default gdbarch methods where possible
  gdb/score: Use default gdbarch methods where possible
  gdb/sh: Use default gdbarch methods where possible
  gdb/sparc: Use default_unwind_pc
  gdb/tic6x: Use default gdbarch methods where possible
  gdb/tilegx: Use default gdbarch methods where possible
  gdb/v850: Use default gdbarch methods where possible
  gdb/vax: Use default gdbarch methods where possible
  gdb/xstormy16: Use default gdbarch methods where possible
  gdb/rl78: Use default gdbarch methods where possible
  gdb/s12z: Use default gdbarch methods where possible

 gdb/ChangeLog        | 185 +++++++++++++++++++++++++++++++++++++++++++++++++++
 gdb/iq2000-tdep.c    |  22 ------
 gdb/lm32-tdep.c      |  23 -------
 gdb/m32c-tdep.c      |  34 ----------
 gdb/m32r-tdep.c      |  37 -----------
 gdb/m68hc11-tdep.c   |  24 -------
 gdb/mep-tdep.c       |  29 --------
 gdb/mips-tdep.c      |  24 -------
 gdb/mn10300-tdep.c   |  32 +--------
 gdb/moxie-tdep.c     |  33 ---------
 gdb/msp430-tdep.c    |  32 ---------
 gdb/nds32-tdep.c     |  28 --------
 gdb/nios2-tdep.c     |  20 ------
 gdb/or1k-tdep.c      |   9 ---
 gdb/rl78-tdep.c      |   9 ---
 gdb/rs6000-tdep.c    |  18 -----
 gdb/rx-tdep.c        |  38 +----------
 gdb/s12z-tdep.c      |  18 -----
 gdb/score-tdep.c     |  23 -------
 gdb/sh-tdep.c        |  25 -------
 gdb/sparc-tdep.c     |   9 ---
 gdb/tic6x-tdep.c     |  24 +------
 gdb/tilegx-tdep.c    |  26 --------
 gdb/v850-tdep.c      |  25 -------
 gdb/vax-tdep.c       |   7 --
 gdb/xstormy16-tdep.c |  23 -------
 26 files changed, 189 insertions(+), 588 deletions(-)

-- 
2.14.5

Comments

Kevin Buettner March 27, 2019, 10:41 p.m. | #1
On Wed, 27 Mar 2019 21:33:56 +0000
Andrew Burgess <andrew.burgess@embecosm.com> wrote:

> I've CC'd target maintainers where I can find any in the hope people

> might test their own target, however, not every target has an obvious

> maintainer, so some are going to rely on review only.


I've provided either comments or okays on the targets that I used
to deal with.  I read through the code only as I no longer have build
environments in place for most (or any?) of those targets.

I skimmed the others too.  The ones that I didn't explicitly okay or
provide comments LGTM, but you should probably wait a few days for
other feedback.

The only one which I think should NOT go in is the patch for
mips-tdep.c.  I think I asked you to extend the ChangeLog remark
for one of the other ones.

Kevin
Andrew Burgess April 23, 2019, 10:13 p.m. | #2
* Andrew Burgess <andrew.burgess@embecosm.com> [2019-03-27 21:33:56 +0000]:

> This series follows on from this one:

> 

>   https://www.sourceware.org/ml/gdb-patches/2018-12/msg00358.html

> 

> This series removes the dummy_id, unwind_pc, and unwind_sp gdbarch

> methods from some targets in cases where it seems obvious that the

> default method, and the method being deleted are the same.

> 

> I've CC'd target maintainers where I can find any in the hope people

> might test their own target, however, not every target has an obvious

> maintainer, so some are going to rely on review only.

> 

> This series addresses all of the targets not addressed in the first

> round.

> 

> A final note, all of these patches are independent, each should apply

> cleanly without the preceding patches, so feel free to review any that

> are of interest, you don't need to apply/review the entire series.

> 

> Thanks,

> Andrew

> 

> --

> 

> Andrew Burgess (25):

>   gdb/iq2000: Use default gdbarch methods where possible

>   gdb/lm32: Use default gdbarch methods where possible

>   gdb/m32c: Use default gdbarch methods where possible

>   gdb/m32r: Use default gdbarch methods where possible

>   gdb/m68hc11: Use default gdbarch methods where possible

>   gdb/mep: Use default gdbarch methods where possible

>   gdb/mips: Use default gdbarch methods where possible

>   gdb/mn10300: Use default gdbarch methods where possible

>   gdb/moxie: Use default gdbarch methods where possible

>   gdb/msp430: Use default gdbarch methods where possible

>   gdb/nds32: Use default gdbarch methods where possible

>   gdb/nios2: Use default gdbarch methods where possible

>   gdb/or1k: Use default gdbarch methods where possible

>   gdb/rs6000: Use default gdbarch methods where possible

>   gdb/rx: Use default gdbarch methods where possible

>   gdb/score: Use default gdbarch methods where possible

>   gdb/sh: Use default gdbarch methods where possible

>   gdb/sparc: Use default_unwind_pc

>   gdb/tic6x: Use default gdbarch methods where possible

>   gdb/tilegx: Use default gdbarch methods where possible

>   gdb/v850: Use default gdbarch methods where possible

>   gdb/vax: Use default gdbarch methods where possible

>   gdb/xstormy16: Use default gdbarch methods where possible

>   gdb/rl78: Use default gdbarch methods where possible

>   gdb/s12z: Use default gdbarch methods where possible


I've now pushed this series, except for the mips patch which I've
dropped.

Thanks,
Andrew


> 

>  gdb/ChangeLog        | 185 +++++++++++++++++++++++++++++++++++++++++++++++++++

>  gdb/iq2000-tdep.c    |  22 ------

>  gdb/lm32-tdep.c      |  23 -------

>  gdb/m32c-tdep.c      |  34 ----------

>  gdb/m32r-tdep.c      |  37 -----------

>  gdb/m68hc11-tdep.c   |  24 -------

>  gdb/mep-tdep.c       |  29 --------

>  gdb/mips-tdep.c      |  24 -------

>  gdb/mn10300-tdep.c   |  32 +--------

>  gdb/moxie-tdep.c     |  33 ---------

>  gdb/msp430-tdep.c    |  32 ---------

>  gdb/nds32-tdep.c     |  28 --------

>  gdb/nios2-tdep.c     |  20 ------

>  gdb/or1k-tdep.c      |   9 ---

>  gdb/rl78-tdep.c      |   9 ---

>  gdb/rs6000-tdep.c    |  18 -----

>  gdb/rx-tdep.c        |  38 +----------

>  gdb/s12z-tdep.c      |  18 -----

>  gdb/score-tdep.c     |  23 -------

>  gdb/sh-tdep.c        |  25 -------

>  gdb/sparc-tdep.c     |   9 ---

>  gdb/tic6x-tdep.c     |  24 +------

>  gdb/tilegx-tdep.c    |  26 --------

>  gdb/v850-tdep.c      |  25 -------

>  gdb/vax-tdep.c       |   7 --

>  gdb/xstormy16-tdep.c |  23 -------

>  26 files changed, 189 insertions(+), 588 deletions(-)

> 

> -- 

> 2.14.5

>