[v2,00/12] Work toward making psymtabs reusable

Message ID 20181125192043.8405-1-tom@tromey.com
Headers show
Series
  • Work toward making psymtabs reusable
Related show

Message

Tom Tromey Nov. 25, 2018, 7:20 p.m.
This is version 2 of my series to improve psymtabs a bit.  In
particular this moves most psymtab allocation to a special obstack, to
make it simpler to reason about.  Mostly this is preparation for
(hopeful) future patches to make psymtabs independent of the objfile.

Version 1 was here:

https://sourceware.org/ml/gdb-patches/2018-05/msg00276.html

... with reviews mostly happening in July.

This addresses all the review comments.  I've also dropped the patch
that removed the psymtab->symtab backlink and updated various comments
accordingly.  That patch caused a small performance regression, and in
the absence of supporting comments it seemed simpler to remove it.  I
may make another push for it later, when it's more needed.

Regression tested on the buildbot.

Tom

Comments

Tom Tromey Jan. 10, 2019, 2:09 p.m. | #1
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:


Tom> This is version 2 of my series to improve psymtabs a bit.
...
Tom> This addresses all the review comments.  I've also dropped the patch
Tom> that removed the psymtab->symtab backlink and updated various comments
Tom> accordingly.

I've rebased this and fixed it up as needed, and re-run it through the
buildbot (just "Fedora-x86_64-m64").  I'm checking it in now.

Tom