[v3,0/7] Use more flags parameters instead of global bits in stdio

Message ID 20181115214449.19262-1-gabriel@inconstante.eti.br
Headers show
Series
  • Use more flags parameters instead of global bits in stdio
Related show

Message

Gabriel F. T. Gomes Nov. 15, 2018, 9:44 p.m.
Patches 2, 3, and 5 did not change, but since they depend on previous
patches in this set, I'm sending them again for completeness.

I added a `Changed since v2' section to each patch in the set describing
the changes.  But I didn't mention the removal of DCO's signed-off-by in
each one of them to avoid repetition.

Also, I'm using `git format-patch -M90% -C', as suggested by Adhemerval.

Thank you.

Zack Weinberg (7):
  Add __vfscanf_internal and __vfwscanf_internal with flags arguments.
  Use SCANF_ISOC99_A instead of _IO_FLAGS2_SCANF_STD.
  Use SCANF_LDBL_IS_DBL instead of __ldbl_is_dbl.
  Add __v*printf_internal with flags arguments
  Add __vsyslog_internal, with same flags as __v*printf_internal.
  Use PRINTF_FORTIFY instead of _IO_FLAGS2_FORTIFY (bug 11319)
  Use PRINTF_LDBL_IS_DBL instead of __ldbl_is_dbl.

 argp/argp-fmtstream.c                            |    3 +-
 argp/argp-help.c                                 |    4 +-
 argp/argp-namefrob.h                             |    2 -
 debug/Makefile                                   |    2 +-
 debug/asprintf_chk.c                             |   20 +-
 debug/dprintf_chk.c                              |   20 +-
 debug/fprintf_chk.c                              |   20 +-
 debug/fwprintf_chk.c                             |   20 +-
 debug/obprintf_chk.c                             |   96 +-
 debug/printf_chk.c                               |   20 +-
 debug/snprintf_chk.c                             |   24 +-
 debug/sprintf_chk.c                              |   25 +-
 debug/swprintf_chk.c                             |   27 +-
 debug/vasprintf_chk.c                            |   68 +-
 debug/vdprintf_chk.c                             |   37 +-
 debug/vfprintf_chk.c                             |   21 +-
 debug/vfwprintf_chk.c                            |   21 +-
 stdio-common/scanf.c => debug/vobprintf_chk.c    |   25 +-
 debug/vprintf_chk.c                              |   20 +-
 debug/vsnprintf_chk.c                            |   46 +-
 debug/vsprintf_chk.c                             |   69 +-
 debug/vswprintf_chk.c                            |   51 +-
 debug/vwprintf_chk.c                             |   21 +-
 debug/wprintf_chk.c                              |   21 +-
 hurd/vpprintf.c                                  |    2 +-
 include/stdio.h                                  |    8 -
 include/sys/syslog.h                             |   19 +-
 include/wchar.h                                  |   12 -
 libio/fwprintf.c                                 |    2 +-
 libio/iolibio.h                                  |    8 -
 libio/iovdprintf.c                               |   13 +-
 libio/iovsprintf.c                               |   66 +-
 libio/iovsscanf.c                                |   12 +-
 libio/iovswscanf.c                               |   14 +-
 libio/libio.h                                    |    8 -
 libio/libioP.h                                   |   97 +-
 libio/obprintf.c                                 |   19 +-
 libio/strfile.h                                  |   33 +-
 libio/swprintf.c                                 |    2 +-
 libio/swscanf.c                                  |   10 +-
 libio/vasprintf.c                                |   20 +-
 libio/vscanf.c                                   |    2 +-
 libio/vsnprintf.c                                |   16 +-
 libio/vswprintf.c                                |   16 +-
 libio/vwprintf.c                                 |    2 +-
 libio/vwscanf.c                                  |    2 +-
 libio/wprintf.c                                  |    2 +-
 libio/wscanf.c                                   |    2 +-
 misc/syslog.c                                    |   36 +-
 stdio-common/Makefile                            |    4 +-
 stdio-common/Versions                            |    3 +
 stdio-common/asprintf.c                          |    6 +-
 stdio-common/dprintf.c                           |    5 +-
 stdio-common/fprintf.c                           |    2 +-
 stdio-common/fxprintf.c                          |    4 +-
 stdio-common/{isoc99_scanf.c => iovfscanf.c}     |   36 +-
 stdio-common/{isoc99_scanf.c => iovfwscanf.c}    |   36 +-
 stdio-common/isoc99_fscanf.c                     |    7 +-
 stdio-common/isoc99_scanf.c                      |   12 +-
 stdio-common/isoc99_sscanf.c                     |    8 +-
 stdio-common/isoc99_vfscanf.c                    |    9 +-
 stdio-common/isoc99_vscanf.c                     |    9 +-
 stdio-common/isoc99_vsscanf.c                    |   16 +-
 stdio-common/printf.c                            |    3 +-
 stdio-common/scanf.c                             |    2 +-
 stdio-common/snprintf.c                          |    4 +-
 stdio-common/sprintf.c                           |    4 +-
 stdio-common/sscanf.c                            |   12 +-
 stdio-common/{vfprintf.c => vfprintf-internal.c} |   60 +-
 stdio-common/vfprintf.c                          | 2351 +----------------
 stdio-common/{vfscanf.c => vfscanf-internal.c}   |   42 +-
 stdio-common/vfscanf.c                           | 3042 +---------------------
 stdio-common/vfwprintf-internal.c                |    2 +
 stdio-common/vfwprintf.c                         |   28 +-
 stdio-common/vfwscanf-internal.c                 |    2 +
 stdio-common/vfwscanf.c                          |   28 +-
 stdio-common/vprintf.c                           |    4 +-
 stdlib/strfrom-skeleton.c                        |    2 +-
 sysdeps/generic/math_ldbl_opt.h                  |    5 +-
 sysdeps/generic/stdio-lock.h                     |    7 -
 sysdeps/ieee754/ldbl-opt/Makefile                |    2 +-
 sysdeps/ieee754/ldbl-opt/math_ldbl_opt.h         |   13 +-
 sysdeps/ieee754/ldbl-opt/nldbl-compat.c          |  773 +++---
 sysdeps/nptl/stdio-lock.h                        |    7 -
 wcsmbs/isoc99_fwscanf.c                          |    7 +-
 wcsmbs/isoc99_swscanf.c                          |   11 +-
 wcsmbs/isoc99_vfwscanf.c                         |    9 +-
 wcsmbs/isoc99_vswscanf.c                         |   15 +-
 wcsmbs/isoc99_vwscanf.c                          |    9 +-
 wcsmbs/isoc99_wscanf.c                           |    7 +-
 90 files changed, 1004 insertions(+), 6710 deletions(-)
 copy stdio-common/scanf.c => debug/vobprintf_chk.c (61%)
 copy stdio-common/{isoc99_scanf.c => iovfscanf.c} (54%)
 copy stdio-common/{isoc99_scanf.c => iovfwscanf.c} (54%)
 copy stdio-common/{vfprintf.c => vfprintf-internal.c} (98%)
 copy stdio-common/{vfscanf.c => vfscanf-internal.c} (98%)
 create mode 100644 stdio-common/vfwprintf-internal.c
 create mode 100644 stdio-common/vfwscanf-internal.c

-- 
2.14.5

Comments

Florian Weimer Dec. 2, 2018, 11:53 a.m. | #1
* Gabriel F. T. Gomes:

> Patches 2, 3, and 5 did not change, but since they depend on previous

> patches in this set, I'm sending them again for completeness.

>

> I added a `Changed since v2' section to each patch in the set describing

> the changes.  But I didn't mention the removal of DCO's signed-off-by in

> each one of them to avoid repetition.

>

> Also, I'm using `git format-patch -M90% -C', as suggested by Adhemerval.


What's the status here?

I think Adhemerval has reviewed all seven patches (and I looked at an
earlier version too), so this should be ready to commit.

Thanks,
Florian
Gabriel F. T. Gomes Dec. 3, 2018, 1:52 p.m. | #2
On Sun, 02 Dec 2018, Florian Weimer wrote:

>What's the status here?

>

>I think Adhemerval has reviewed all seven patches (and I looked at an

>earlier version too), so this should be ready to commit.


I'll try to get back to it today (no later than tomorrow).

Thanks for your reviews.
Gabriel F. T. Gomes Dec. 5, 2018, 9 p.m. | #3
On Mon, 03 Dec 2018, Gabriel F. T. Gomes wrote:

>On Sun, 02 Dec 2018, Florian Weimer wrote:

>

>>What's the status here?

>>

>>I think Adhemerval has reviewed all seven patches (and I looked at an

>>earlier version too), so this should be ready to commit.  

>

>I'll try to get back to it today (no later than tomorrow).

>

>Thanks for your reviews.


These patches (with the regression test) are now committed and the
bugzilla entry is now marked as resolved/fixed.  Thanks again.